Fix reference MapType dataset comparisons - #1466
Open
mattfaltyn wants to merge 2 commits into
Open
Conversation
mattfaltyn
marked this pull request as ready for review
August 13, 2026 07:49
mattfaltyn
requested review from
pratikk-databricks
and removed request for
a team
August 13, 2026 07:49
ghanse
approved these changes
Aug 13, 2026
ghanse
left a comment
ghanse
left a comment
Collaborator
There was a problem hiding this comment.
This looks good overall.
ghanse
added
the
Approved to Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
compare_datasetswhen either the source or reference schema declares them asMapType.This keeps dataset comparison symmetric and restores the documented behavior that MapType comparisons are skipped automatically.
Linked issues
Resolves #1465
Tests
Local validation:
make fmtmake lintmake test— 2,327 passedThe focused integration cases require the repository's Databricks workspace test environment, which is not configured locally. Per the fork-contribution workflow, a maintainer must approve the standard workflows and trigger the integration and end-to-end suites.
Documentation and Demos
No documentation change is needed: the existing
compare_datasetsdocumentation already states that any MapType column comparison is skipped automatically. This PR aligns the implementation with that contract.