fix: Scalar typetracer after reduction - #529
Open
martindurant wants to merge 2 commits into
Open
Conversation
martindurant
commented
Jul 29, 2024
| meta = op(other, self._meta) | ||
| else: | ||
| meta = op(self._meta, other) | ||
| if meta.ndim: |
Collaborator
Author
There was a problem hiding this comment.
This applies to the scenario, which apparently we hadn't anticipated, that an operation on a scalar produces an array.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 93.06% 92.91% -0.16%
==========================================
Files 23 23
Lines 3290 3389 +99
==========================================
+ Hits 3062 3149 +87
- Misses 228 240 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
martindurant
commented
Jul 29, 2024
| args = tuple( | ||
| ak.Array(arg.content) if isinstance(arg, MaybeNone) else arg for arg in args | ||
| ) | ||
| args = tuple( |
Collaborator
Author
There was a problem hiding this comment.
Here we account for getting the low-level typetracer through during column optimisation. This is the questionable part.
martindurant
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #528
This appears to fix the linked issue, but I'm not really sure why a typetracer object is being passed around rather than a high-level Array.