Repository navigation
chore(ci): run PR Hygiene's engine from master - #1528
Conversation
The caller pinned the shared engine to one commit, so every engine fix needed a re-pin here before it took effect. The engine is now named by `master` of dashpay/stale_prs_are_bad — the protected branch the review policy is already read from — and the reusable workflow still requires the commit it runs to be merged there (dashpay/stale_prs_are_bad#73). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: dashpay/tenderdash/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — Phase 1 only — no blockers (commit 9e31a15) · triage: trivial |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final review — Phase 1 only (trivial change)
The PR makes the intended one-line change, switching the reusable PR Hygiene workflow from a pinned commit to the master branch of dashpay/stale_prs_are_bad. The supplied evidence confirms the referenced workflow and upstream protections are in place, and the policy reconciliation check succeeded; no in-scope defects were found.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)
- Triage:
trivialbygpt-6.1-sol(effort low) — The diff changes a single GitHub Actions workflow reference from a pinned commit to the master branch, with no application behavior or critical runtime surface affected. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 99% left, weekly 71% left; passed overgemini-3.8-flash-high(antigravity below 15% reserve: weekly 70% left, 5h 12% left) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-gate-verifier - Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
|
Bots are done — your move: post |
What
This repo's PR Hygiene caller now runs the shared engine from
masterofdashpay/stale_prs_are_badinstead of a pinned commit:Why
With a pinned commit, every engine fix needs a re-pin PR here before it takes effect. The engine fixes merged this week (review bots that open PRs, "your part" per area, branch patterns) haven't reached this repo yet. Meanwhile the review policy is already read live from that same
master, so pinned engines and the live policy can drift apart.Security trade-off (please review)
Naming a branch instead of a SHA means engine upgrades are reviewed in
dashpay/stale_prs_are_bad, not here. The controls there:protect-master: changes need a pull request with code-owner review and the requiredtest/checkCI. Force-push and deletion are blocked.no-tag-shadows-master: amastertag is forbidden, with no bypass. GitHub would resolve a tag before the branch.master(feat: a caller may run the engine from master stale_prs_are_bad#73).Verified in a real run: dashpay/grovedb run 36953611829, caller on
@master, succeeded.🤖 Generated with Claude Code
PR Hygiene ·
9e31a15/self-reviewedgithub(.github/workflows/pr-review-policy.yml) — ktechmidasWhen every box is checked the
PR Hygienecheck passes and this can merge.