Repository navigation
chore(release): update changelog and bump version to 1.6.0-dev.2 - #1361
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit 20589c5) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Release-chore PR correctly bumps the version constant but the CHANGELOG edit is structurally broken: the existing 1.6.0-dev.1 header was renamed in place to 1.6.0-dev.2 (instead of inserting a new section above it), so the already-tagged dev.1 release history is no longer addressable and a user-visible WS Origin behavior-change note from #1343 was silently dropped. Both findings independently verified against the diff, the v1.6.0-dev.1 tag, and the project's prior release pattern (e.g. 1.5.0-dev.2 over 1.5.0-dev.1). Codex returned no findings and CodeRabbit was empty.
🔴 2 blocking
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `CHANGELOG.md`:
- [BLOCKING] CHANGELOG.md:1: 1.6.0-dev.1 section overwritten instead of preserved
The diff renames `## [1.6.0-dev.1] - 2026-06-12` to `## [1.6.0-dev.2] - 2026-06-19` and merges new bullets into the same section, even though `v1.6.0-dev.1` already exists as a tag (visible in `git tag`). Every prior release in this CHANGELOG (e.g. 1.5.0-dev.2 over 1.5.0-dev.1) was added as a NEW header above the prior one with only its own bullets. As written, the dev.1 release notes are no longer addressable and bullets that belong exclusively to dev.1 (#1245, #1329, #1331, #1314, #1334, #1252, #1248, #1249, #1250, #1258, #1263, #1336, #1333, and the entire dev.1 dependabot block) are now attributed to dev.2. The clearest symptom is that the dev.1 release chore itself — `Update changelog and version to 1.6.0-dev.1 (#1337)` — is now listed under dev.2's Miscellaneous Tasks, which is logically impossible. Fix: restore the dev.1 section verbatim and insert a new `## [1.6.0-dev.2] - 2026-06-19` section above it containing only the items merged since #1337.
- [BLOCKING] CHANGELOG.md:15: Dropped the WS Origin / cross-origin behavior-change note from #1343
The diff removes the existing line `Restrict websocket upgrades to same-host and Origin-less requests by default; browser WS clients on cross-origin hosts must now be listed in cors-allowed-origins (#1343)` and replaces it with only the generic `Add input validation and request bounds (#1343)`. The removed line documents a real default-policy change shipped in #1343 and is the only in-changelog warning operators get that browser WS clients on other origins will start being rejected after upgrade. Restore it (in the dev.1 section per the previous finding) so the behavior change is not silently lost.
Issue being fixed or feature implemented
Release new Tenderdash version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only