Skip to content

fix(p2p): ignore invalid host when loading peer db - #1243

Merged
lklimek merged 1 commit into
v1.5-devfrom
fix/ignore-invalid-peerdb-records
Jan 28, 2026
Merged

lklimek merged 1 commit into
v1.5-devfrom
fix/ignore-invalid-peerdb-records

Conversation

@lklimek

@lklimek lklimek commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

On mainnet, we've hit invalid records in the peer database:

ERROR: failed to create node: error="failed to create peer manager: failed to create peer manager: invalid peer data: invalid address \"\": invalid node address \"mconn://0d3c71247defe841a0ed8169788a9aa3a170e3e4@[173.199.71.83:26656]:26656\": parse \"mconn://0d3c71247defe841a0ed8169788a9aa3a170e3e4@[173.199.71.83:26656]:26656\": invalid host: ParseAddr(\"173.199.71.83:26656\"): unexpected character (at \":26656\")" closerError=""

What was done?

Ignoring invalid records, emitting error log.

Worst case scenario is that the node will need to sync with seeds on restart.

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai

coderabbitai Bot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lklimek
lklimek changed the base branch from v1.5-dev to v1.6-dev January 28, 2026 09:39
@lklimek
lklimek changed the base branch from v1.6-dev to v1.5-dev January 28, 2026 09:39
@lklimek
lklimek merged commit b5501d8 into v1.5-dev Jan 28, 2026
25 of 26 checks passed
@lklimek
lklimek deleted the fix/ignore-invalid-peerdb-records branch January 28, 2026 10:59
@lklimek lklimek mentioned this pull request Jan 28, 2026
1 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant