Skip to content

fix(dash-spv-ffi): encode the truncated wallet id with hex-conservative - #1153

Merged
xdustinface merged 1 commit into
dashpay:devfrom
PastaPastaPasta:fix/dash-spv-ffi-hex-conservative
Oct 12, 2026
Merged

xdustinface merged 1 commit into
dashpay:devfrom
PastaPastaPasta:fix/dash-spv-ffi-hex-conservative

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

dev doesn't compile dash-spv-ffi. #1104 added two hex::encode(wallet_id) calls in the chain-truncated callback (dash-spv-ffi/src/callbacks.rs), but #1115, merged just before it, had moved the workspace off the hex crate. Each was green on its own base. Together they fail with error[E0433]: cannot find module or crate 'hex', which fails the ffi, ASan and other jobs on every open PR.

The two calls now use DisplayHex::to_lower_hex_string(), which the same file already imports and uses for the swept-transactions warning just above. The output is the same lowercase hex.

Tests

  • cargo clippy --workspace --all-targets --all-features -- -D warnings passes on this branch.
  • cargo fmt --check passes.

Breaking changes

None.

🤖 Generated with Claude Code

PR Hygiene · 91339e5

  • Bots — coderabbitai not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed
  • Build running
  • Approvals
    • files with no dedicated owner (dash-spv-ffi/src/callbacks.rs) — QuantumExplorer or ZocoLini or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

dashpay#1104 added two `hex::encode` calls in the chain-truncated callback,
but dashpay#1115 had already moved the workspace off the `hex` crate, so
`dash-spv-ffi` stops compiling on dev. Use `DisplayHex`, as the rest
of the file does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: dashpay/rust-dashcore/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 86232236-8735-4272-9e54-40d6feb456f4

📥 Commits

Reviewing files that changed from the base of the PR and between 04359e5 and 91339e5.


📒 Files selected for processing (1)
  • dash-spv-ffi/src/callbacks.rs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 12, 2026
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.31%. Comparing base (04359e5) to head (91339e5).

Files with missing lines Patch % Lines
dash-spv-ffi/src/callbacks.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1153      +/-   ##
==========================================
- Coverage   82.50%   78.31%   -4.19%     
==========================================
  Files         268      298      +30     
  Lines       68852    79480   +10628     
==========================================
+ Hits        56807    62247    +5440     
- Misses      12045    17233    +5188     
Flag Coverage Δ
core 76.44% <ø> (ø)
ffi 51.19% <0.00%> (?)
rpc 49.36% <ø> (ø)
spv 92.47% <ø> (-0.01%) ⬇️
wallet 82.07% <ø> (ø)
Files with missing lines Coverage Δ
dash-spv-ffi/src/callbacks.rs 82.09% <0.00%> (ø)

... and 37 files with indirect coverage changes

@xdustinface
xdustinface merged commit 6e7d339 into dashpay:dev Oct 12, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants