Repository navigation
fix(dash-spv-ffi): encode the truncated wallet id with hex-conservative - #1153
Conversation
dashpay#1104 added two `hex::encode` calls in the chain-truncated callback, but dashpay#1115 had already moved the workspace off the `hex` crate, so `dash-spv-ffi` stops compiling on dev. Use `DisplayHex`, as the rest of the file does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1153 +/- ##
==========================================
- Coverage 82.50% 78.31% -4.19%
==========================================
Files 268 298 +30
Lines 68852 79480 +10628
==========================================
+ Hits 56807 62247 +5440
- Misses 12045 17233 +5188
|
devdoesn't compiledash-spv-ffi. #1104 added twohex::encode(wallet_id)calls in the chain-truncated callback (dash-spv-ffi/src/callbacks.rs), but #1115, merged just before it, had moved the workspace off thehexcrate. Each was green on its own base. Together they fail witherror[E0433]: cannot find module or crate 'hex', which fails the ffi, ASan and other jobs on every open PR.The two calls now use
DisplayHex::to_lower_hex_string(), which the same file already imports and uses for the swept-transactions warning just above. The output is the same lowercase hex.Tests
cargo clippy --workspace --all-targets --all-features -- -D warningspasses on this branch.cargo fmt --checkpasses.Breaking changes
None.
🤖 Generated with Claude Code
PR Hygiene ·
91339e5/skip-botsproceeds without the ones not yet reported/self-revieweddash-spv-ffi/src/callbacks.rs) — QuantumExplorer or ZocoLini or xdustinfaceWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.