Skip to content

fix(dash-spv): stop a client that is still starting - #1101

Merged
ZocoLini merged 2 commits into
devfrom
fix/spv-client-stop-during-start
Oct 3, 2026
Merged

ZocoLini merged 2 commits into
devfrom
fix/spv-client-stop-during-start

fix(dash-spv): stop only a sync loop that failed

4cef656
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2026 in 0s

77.57% (+0.14%) compared to 7c1f6be

View this Pull Request on Codecov

77.57% (+0.14%) compared to 7c1f6be

Details

Codecov Report

❌ Patch coverage is 68.88889% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.57%. Comparing base (7c1f6be) to head (4cef656).

Files with missing lines Patch % Lines
dash-spv/src/client/sync_coordinator.rs 70.37% 16 Missing ⚠️
dash-spv/src/client/lifecycle.rs 72.00% 7 Missing ⚠️
dash-spv-ffi/src/client.rs 50.00% 3 Missing ⚠️
dash-spv/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1101      +/-   ##
==========================================
+ Coverage   77.42%   77.57%   +0.14%     
==========================================
  Files         320      320              
  Lines       81338    81328      -10     
==========================================
+ Hits        62976    63088     +112     
+ Misses      18362    18240     -122     
Files with missing lines Coverage Δ
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% <ø> (ø)
dash-spv/src/client/core.rs 66.00% <100.00%> (-6.00%) ⬇️
dash-spv/src/client/mod.rs 100.00% <ø> (ø)
dash-spv/src/lib.rs 46.66% <ø> (ø)
dash-spv/src/main.rs 55.48% <0.00%> (+1.22%) ⬆️
dash-spv-ffi/src/client.rs 43.93% <50.00%> (-6.52%) ⬇️
dash-spv/src/client/lifecycle.rs 89.69% <72.00%> (-1.46%) ⬇️
dash-spv/src/client/sync_coordinator.rs 74.77% <70.37%> (-3.58%) ⬇️

... and 26 files with indirect coverage changes