Skip to content

fix(ui): report AddNewIdentity screen type for the create-identity screen - #1045

Merged
lklimek merged 1 commit into
v1.0-devfrom
fix/add-new-identity-screen-type
Oct 2, 2026
Merged

lklimek merged 1 commit into
v1.0-devfrom
fix/add-new-identity-screen-type

Conversation

@lklimek

@lklimek lklimek commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Screen::screen_type() mapped Screen::AddNewIdentityScreen to ScreenType::AddExistingIdentity (copy-paste slip). Because Screen's PartialEq compares by ScreenType, the create- and load-identity screens compared equal, and Debug printed the wrong type.
  • Map it to ScreenType::AddNewIdentity.
  • Add kittest add_identity_screens_report_their_own_screen_type (fails before the fix, passes after).

Follow-up to review finding RUST-004 on #1042 (pre-existing, out of that PR's scope).

Test plan

  • cargo test --test kittest --all-features add_identity_screens_report_their_own_screen_type — red without fix, green with it

🤖 Generated with Claude Code

PR Hygiene · 4122010

  • Bots — coderabbitai skipped by lklimek · thepastaclaw skipped by lklimek
  • Self-review — posted; again after any push
  • Within your 5 open PRs
  • Build green
  • Approvals — you own every area touched; none needed

When every box is checked the PR Hygiene check passes and this can merge.

…reen

Screen::AddNewIdentityScreen mapped to ScreenType::AddExistingIdentity
(copy-paste slip), so Screen's PartialEq treated the create and load
identity screens as equal and Debug printed the wrong type.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/dash-evo-tool/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c8f24c53-8129-43f0-a740-7735e41c26e3

📥 Commits

Reviewing files that changed from the base of the PR and between 104c554 and 4122010.

📒 Files selected for processing (2)
  • src/ui/mod.rs
  • tests/kittest/identity_hub_onboarding.rs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 2, 2026
@thepastaclaw

thepastaclaw commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 3rd in line, estimated start in ~5 min (commit 4122010)
Estimated review time once started: ~30 min (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@lklimek

lklimek commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

/skip-bots
/self-reviewed

@lklimek
lklimek enabled auto-merge (squash) October 2, 2026 08:10
@lklimek

lklimek commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

/skip-bots

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Oct 2, 2026
@lklimek

lklimek commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

/self-reviewed

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Policy satisfied — this can merge.
Full checklist in the description.

@github-actions github-actions Bot removed the waiting-self-review Waiting for the author to post /self-reviewed label Oct 2, 2026
@lklimek
lklimek merged commit a81996c into v1.0-dev Oct 2, 2026
7 checks passed
@lklimek
lklimek deleted the fix/add-new-identity-screen-type branch October 2, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants