Repository navigation
fix(ui): report AddNewIdentity screen type for the create-identity screen - #1045
Conversation
…reen Screen::AddNewIdentityScreen mapped to ScreenType::AddExistingIdentity (copy-paste slip), so Screen's PartialEq treated the create and load identity screens as equal and Debug printed the wrong type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: dashpay/dash-evo-tool/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 3rd in line, estimated start in ~5 min (commit 4122010)
|
|
/skip-bots |
|
/skip-bots |
|
Bots are done — your move: post |
|
Bots are done — your move: post |
|
/self-reviewed |
|
Policy satisfied — this can merge. |
Summary
Screen::screen_type()mappedScreen::AddNewIdentityScreentoScreenType::AddExistingIdentity(copy-paste slip). BecauseScreen'sPartialEqcompares byScreenType, the create- and load-identity screens compared equal, andDebugprinted the wrong type.ScreenType::AddNewIdentity.add_identity_screens_report_their_own_screen_type(fails before the fix, passes after).Follow-up to review finding RUST-004 on #1042 (pre-existing, out of that PR's scope).
Test plan
cargo test --test kittest --all-features add_identity_screens_report_their_own_screen_type— red without fix, green with it🤖 Generated with Claude Code
PR Hygiene ·
4122010When every box is checked the
PR Hygienecheck passes and this can merge.