Repository navigation
Conversation
Keep manual Platform funding signing inside the wallet backend secret session and reject invitation vouchers. Exercise credit-key lookup without the legacy address cache. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
🕓 Review not started yet because this PR is a draft.
Commit 9cf5456. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Bring in the latest v1.0-dev merged into the fix/orphaned-tx base. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Funding a Platform address from a saved deposit now works when the wallet owns its signing key but the address is absent from DET's local address list.
User story
As a wallet user, I can reuse an existing funding deposit without a misleading missing-address error.
Scenario
In Wallets → Dash Core → Asset Locks, choose Fund for an unused deposit and a destination outside the upstream wallet address pool. Previously this could fail despite a valid funding proof. The deposit can now fund the destination. Deposits reserved for DashPay invitations are rejected before signing.
Detailed discussion
Stacked on #1028 (
fix/orphaned-tx). No dependency pin changes.The manual funding path now resolves the tracked outpoint through
resume_asset_lock, derives the returned funding-account path, and signs inside one wallet-backend secret session. It no longer relies onWallet::known_addressesfor the credit-output key or accesses seed material in the backend task.Validation:
AssetLockAddressNotFoundbefore the fix withknown_locally=falseand a proof present.cargo fmt --all -- --check, scoped Clippy (--locked --test backend-e2e --all-features -- -D warnings), andgit diff --checkpassed.The non-pool SDK submission retains its existing consumption/retry behavior; this change fixes key resolution. The independent SQLite
wallet_restorereconciliation error is fixed separately in dashpay/platform#5207 and integrated into DET by #1036. This is a draft, so automatic PR CI is suppressed.🤖 Co-authored by Claudius the Magnificent AI Agent