Repository navigation
Rename the job-status tools to -get; crawl-cancel is destructive - #81
Merged
Merged
Conversation
ethora-broadcast-job-start and ethora-user-batch-job-start fetched a job by id and never started anything; the directory scanner flagged the names as inconsistent with behaviour. Renamed to -get with the old names as aliases. Cancelling a crawl discards its unfinished pages, so it is destructive.
phwizard
force-pushed
the
fix/job-get-names
branch
from
October 16, 2026 17:27
a29ef0d to
1049838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second scanner pass on 26.10.2:
ethora-broadcast-job-startandethora-user-batch-job-start'name inconsistent with behaviour' (they fetch a job by id);ethora-source-site-crawl-cancel'destructiveHint false but hard-to-reverse'. Renamed to-getwith the old names kept as aliases in toolNames.ts; crawl-cancel marked destructive (it discards the unfinished part of a crawl). Variant notes corrected (they were described as async variants). 22/22 tests.