Misc refactoring parsing - #950
Merged
Merged
Conversation
pgiraud
force-pushed
the
misc_refactoring_parsing
branch
8 times, most recently
from
August 19, 2026 11:51
fcc2ac3 to
a085b50
Compare
pgiraud
force-pushed
the
misc_refactoring_parsing
branch
2 times, most recently
from
August 25, 2026 08:14
7edfaf7 to
8097cec
Compare
Follow-up for 3787ad4
Instead use a revised field for that. Same for ACTUAL_STARTUP_TIME.
And set it to true when relevant.
We now search for files with `-plan` suffix and determine the corresponding `-expect` file.
Right|Left Semi|Anti In the tests, I had to manually delete some keys in the expect file because it's impossible to determine them from the text format. It's the case for Inner Unique key which appears systematically in the JSON format but doesn't appear in text.
InitPlan and SubPlan relationship is already set earlier. For other cases, for: - Join nodes (Nested Loop, Merge Join, Hash Join), the first child is "Outer", the others are "Inner", - Append and Bitmap, relationship is "Member", - Subquery Scan, relationship is "Subquery". A new file is added to from-text list. A SQL script is added to generate both Text and JSON format plans. However, the JSON plan needed to be adapted a bit.
We also improve parsing of Group|Hash|Sort Key to possibly handle Grouping Sets.
pgiraud
force-pushed
the
misc_refactoring_parsing
branch
from
August 26, 2026 11:58
8097cec to
575f701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.