Repository navigation
feat(feed): expand the list card TLDR by tapping it - #6988
Merged
Merged
Conversation
Inside the list_card_tldr experiment, tapping the clamped TLDR or its "Show more" now expands it in place for good. The button then goes away (no "Show less"), and tapping the expanded text opens the post like the rest of the card. "Show more" stretches its hit area over the clamped text with a pseudo-element, so it stays the one accessible control. The TLDR also moves to text-primary and "Show more" to the body's 15px regular weight, matching how X's mobile web sets tweet text: same size and line height as ours (15/20), full-strength color, and an inline "Show more" the size of the text.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #6974, inside the
list_card_tldrexperiment only.CardTldrrenders nothing when the flag is off, so the control arm is unchanged.Interaction
expand tldris still logged once, on the first tap.Copy and type
text-text-secondarytotext-text-primary, and "Show more" fromtypo-footnote(13px) to the body'stypo-callout(15px). X's mobile web sets tweet text at the same 15/20 we use, but at full-strength color with a "Show more" the size of the text, so size and line height stay as they are.Reviewer notes
AgentPostCard: while collapsed, the wrapper isrelative z-1above the card link and the button'safter:absolute after:inset-0covers it. "Show more" stays the single accessible control, and once expanded the wrapper drops back under the card link.Testing
CardTldr.spec.tsxandArticleList.spec.tsx, shared card and feed suites, full webapp suitetypecheck-strict-changed, full webapptscPreview domain
https://claude-gist-mode-click-behavior.preview.app.daily.dev