Repository navigation
feat(storybook): card actions exploration — bigger feed-card buttons - #6835
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2ed23b5 to
46ebf62
Compare
tsahimatsliah
left a comment
There was a problem hiding this comment.
Storybook-only exploration; confirmed the diff touches nothing outside packages/storybook and adds no binaries under packages/storybook/public. One blocking finding (the committed live-feed snapshot carries real user records into a public repo) and a handful of non-blocking ones, inline. Verification: read the diff and compared the selectors and bar markup against ActionButtons.tsx / PostMenuOptions on main and against #6836; I did not run storybook or a typecheck locally (CI's typecheck_strict_changed reports green, but storybook is outside strict typecheck per AGENTS.md).
Reviewed by AI.
Storybook only, no production code. Answers "make the engagement buttons bigger again" after card_imps won, on the real production cards filled with 40 posts from the live feed; only the action bar is swapped. - Experiments/Card actions/1. Decide: overview, side-by-side compare of the shortlist at four grid gaps, a fit check (width each bar needs on every post, card height vs today) and a gap sheet of today's bar at 24px vs 32px. - 2. Explore: before/after feed-gap wipe at real breakpoints, variants on every card type, a variant in the feed down to phone, and a lab. - 3. Research: how 15 products organise card actions, with sources. - Archive/Round 1: the first 12 bar and spacing variants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
46ebf62 to
6b1e8a9
Compare
|
Review follow-up — all 6 threads addressed and resolved Blocking
Non-blocking
Re-verified: all 10 stories render, no slot badges, no external avatar hosts; storybook typecheck clean. |
Drop the @types/react-dom devDependency and its lockfile change. Storybook builds with Vite and isn't type-checked in CI, and existing stories already import react-dom without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Changes
Storybook only — no production code. After
card_impswon, Ido asked to make the feed card's engagement buttons bigger again. Making them bigger by itself looked busy, so this explores the whole system: the bar, the feed's spacing, and what other products do.Every page uses the real production grid/list cards filled with 40 posts from the public feed (
realFeed.json, fetched 2026-10-08), anonymised: every person is a synthetic name with a placeholder avatar, third-party images aremedia.daily.devplaceholders, impressions are synthetic; post titles, publications and squads are kept. Only the action bar is swapped, by DOM slot in Storybook — the cards, layout and spacing are production's; a red "Slot not found" badge appears if a slot ever stops matching production markup.Storybook → Experiments / Card actions
Shortlist: T.1 (today's bar at 32px / 20px icons), C.3 (counts left; downvote · bookmark · copy link right), E.1 (today's order, bookmark moves to the header on hover), E.2 (counts first, bookmark on hover). All keep today's card height (36px bar row; 44px tap areas).
Findings worth knowing
largeNumberFormat.Events
No new tracking events.
Experiment
No experiment in this PR — it's the exploration to decide one.
🤖 Generated with Claude Code
Preview domain
https://card-engagement-buttons-bigger-d.preview.app.daily.dev