Repository navigation
Document Bun's piped console output workarounds - #1011
Conversation
Explain how Bun can drop large piped console output after importing @optique/run, even when parsing succeeds and the process exits naturally. Document stream writes and completion callbacks in the runner JSDoc and VitePress guide, with links to the upstream bug and merged fix. Fixes #1007 Changelog: none Assisted-by: Codex:gpt-6.1-sol
|
@coderabbitai full review |
|
@codex review |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.0-maintenance #1011 +/- ##
===================================================
+ Coverage 88.85% 88.87% +0.01%
===================================================
Files 67 67
Lines 31992 31992
Branches 7520 7524 +4
===================================================
+ Hits 28428 28432 +4
+ Misses 2784 2783 -1
+ Partials 780 777 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04aa28ac02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The synchronous onExit hook cannot await queued stream writes. Explain that custom output handlers must finish synchronously with the default exit handler, and describe throwing an exit signal so the caller can await write completion outside the runner before exiting. #1011 (comment) Changelog: none Assisted-by: Codex:gpt-6.1-sol
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a30cb2101a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Large console.error output can be dropped just like console.log output. Document process.stderr.write for diagnostics alongside the stdout workaround, and warn users of custom stderr handlers in the JSDoc. #1011 (comment) Changelog: none Assisted-by: Codex:gpt-6.1-sol
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Importing
@optique/runcan trigger Bun's silent truncation of large piped console output (see also oven-sh/bun#36419), even after successful parsing and natural exit. The JSDoc and runner guide recommendprocess.stdout.write()and completion callbacks before explicit exit, since delays cannot recover dropped bytes. They also explain why disabling TTY detection is insufficient and link the upstream fix without naming an unverified fixed version.Fixes #1007.