Conversation
Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
…instead of an enum Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
|
Looks very nice, thanks. 
I agree it would be nice to expose The CLI interaction seems noticeably slower however. Did you have the same experience? I'd expect it to be a bit slower given the rich formatting, but this may be borderline. Is there something we can do about it? |
Yeah it's a known issue with building cli's with Typer/Python, there's a handful of discussions about this topic. Importing rich + others seems to cause the slowdown, not rich doing the formatting. Lemme take a look and try some stuff and get back to you. |
Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
|
The main slowdown is when invoking the CLI, we import every package, and I think typer+rich made it slower enough to notice. I tried out
|
ieivanov
left a comment
ieivanov
left a comment
There was a problem hiding this comment.
Looks nice. It's worth getting review from someone else too before you merge
Document the exported greedy `-i` building blocks (OptionEatAll, install_eat_all_positions, InputPositionDirpaths, expand_position_dirpaths) and link the page into the nav. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
I'd say let's merge this PR now, it's important we don't let PRs go state. We can fix any issues that we haven't caught here later. |
Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
…vements Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
2 participants
Typer version
0.26vendors Click instead of depending on it, soOptionEatAllneeded some adjustments.OptionEatAllfor downstream libraries (i.e.biahub) too...