fix(ci): Exempt deprecation warnings from the roxygenize warning gate

[krlmlr]

What this does

#111 wrapped roxygen2::roxygenize() in a withCallingHandlers() that collects every warning and then fails the step. This PR carves deprecation warnings out of that gate. They are still echoed to the job log as ::warning:: annotations, so they stay visible and can be chased upstream, but they no longer fail the step. Every other warning fails it exactly as before — the gate itself stays.

Why deprecation warnings are different

The gate asks the consumer repo to fix what roxygen2 reports. That is the right ask for a malformed tag or a missing @param, but not for a deprecation warning raised inside a third-party roclet package. When a roclet calls a roxygen2 function that roxygen2 has since deprecated, the call site is in the roclet, not in the package being documented. There is nothing to fix in the consumer repo, so the gate is a false positive there — and it is a false positive for every repo on the kit that uses that roclet, not just one.

In igraph/rigraph the gate turned twelve pre-existing warnings into a red main. Eleven are actionable in principle. The twelfth is a lifecycle deprecation from devtag calling roxygen2's deprecated tag_words_line(). That one cannot be fixed in rigraph at all, so under the current gate rigraph could never get back to green by its own effort.

How the match is made

On the condition class, never on the message text. The classes were checked against R 4.5.3 rather than recalled:

• lifecycle::deprecate_warn() → lifecycle_warning_deprecated, rlang_warning, warning, condition
• .Deprecated() → deprecatedWarning, warning, condition
• warning() → simpleWarning, warning, condition

So deprecatedWarning and lifecycle_warning_deprecated separate the two deprecation paths from an ordinary warning, and both are matched.

Test

The handler logic from the action was run verbatim against the three inputs, plus the mixed case that matches the rigraph situation:

=== (a) lifecycle::deprecate_warn() ===
roxygen2 emitted 1 deprecation warning(s), these do not fail the step:
* `tag_words_line()` was deprecated in roxygen2 7.3.0.
::warning title=roxygen2 deprecation::`tag_words_line()` was deprecated in roxygen2 7.3.0.
roxygen2 emitted no warnings that fail the step.
--> PASS -- step succeeds

=== (b) base .Deprecated() ===
roxygen2 emitted 1 deprecation warning(s), these do not fail the step:
* 'old_roclet' is deprecated.
Use 'new_roclet' instead.
See help("Deprecated")
::warning title=roxygen2 deprecation::'old_roclet' is deprecated.%0AUse 'new_roclet' instead.%0ASee help("Deprecated")
roxygen2 emitted no warnings that fail the step.
--> PASS -- step succeeds

=== (c) plain warning() ===
roxygen2 emitted 1 warning(s):
* boom
::warning title=roxygen2::boom
--> FAIL -- step aborts: Fix the roxygen2 warnings above.

=== (d) mixed: two deprecations + one ordinary warning ===
roxygen2 emitted 2 deprecation warning(s), these do not fail the step:
* `tag_words_line()` was deprecated in roxygen2 7.3.0.
* 'f' is deprecated.
Use 'new_roclet' instead.
See help("Deprecated")
::warning title=roxygen2 deprecation::`tag_words_line()` was deprecated in roxygen2 7.3.0.
::warning title=roxygen2 deprecation::'f' is deprecated.%0AUse 'new_roclet' instead.%0ASee help("Deprecated")
roxygen2 emitted 1 warning(s):
* @param x missing
::warning title=roxygen2::@param x missing
--> FAIL -- step aborts (exit code 1)

All three kinds are echoed to the log. The two deprecation kinds pass the gate, the ordinary warning still fails it, and a deprecation alongside an ordinary warning does not mask the failure.

Note on the diff

escape() moved out of the else branch to the top level of the script, because the deprecation annotations need it too. It is otherwise unchanged. The "no warnings" message now reads "no warnings that fail the step", since deprecations may have been reported just above it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Hcbd7RdNjqre33JRgc86j8

---

Generated by Claude Code