Release: 1.18.0 No.2

[infeo]

Reapplication of #20

[coderabbitai]

Walkthrough

This PR updates the Cryptomator Arch Linux package from version 1.17.1 to 1.18.0. It includes version bumps in package metadata, updates source URLs and checksums for both x86_64 and aarch64 architectures, bumps the OpenJFX dependency from 24.0.1 to 25, and modifies the JLINK module list in the build function to add new crypto modules (jdk.crypto.ec and jdk.crypto.cryptoki) while retaining existing modules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Checksum values require verification against official sources for both architectures (x86_64, aarch64)
• JLINK module list modification requires validation that the new crypto modules are appropriate and compatible with the build process
• OpenJFX version bump (24.0.1 → 25) should be verified for compatibility with Cryptomator 1.18.0

Possibly related PRs

• Release 1.18.0 #20: Updates for the same 1.18.0 release with identical checksum and OpenJFX module changes
• Release: 1.15.0 #12: Previous version bump that modifies the same packaging files (.SRCINFO and PKGBUILD) with similar pattern of updates
• Release 1.14.0 #9: Earlier release update that directly modifies the JLINK --add-modules list in the build() function

Suggested reviewers

• SailReal

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description 'Reapplication of #20' is vague and provides no meaningful information about what the changeset actually does or what problem it solves.	Expand the description to explain what changes are included (version bump, dependency updates, etc.) and why this is a reapplication of PR #20.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Release: 1.18.0 No.2' clearly indicates a version release bump from the code changes and accurately summarizes the main objective of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch release/1.18.0

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0169cdc and 64fe608.

📒 Files selected for processing (2)

• .SRCINFO (2 hunks)
• PKGBUILD (3 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: infeo
Repo: cryptomator/aur PR: 7
File: .SRCINFO:23-24
Timestamp: 2024-06-26T09:11:54.167Z
Learning: Checksum values in the `.SRCINFO` file of the `cryptomator` repository are not API keys and should not be flagged as potential security issues.

📚 Learning: 2024-06-26T09:11:54.167Z

Learnt from: infeo
Repo: cryptomator/aur PR: 7
File: .SRCINFO:23-24
Timestamp: 2024-06-26T09:11:54.167Z
Learning: Checksum values in the `.SRCINFO` file of the `cryptomator` repository are not API keys and should not be flagged as potential security issues.

Applied to files:

• .SRCINFO
• PKGBUILD

🪛 Gitleaks (8.29.0)

.SRCINFO

[high] 23-23: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build with makepkg

🔇 Additional comments (5)

PKGBUILD (3)

8-8: Version bumps look correct.

The package version bump to 1.18.0 and OpenJFX update to version 25 align with the PR objectives for this release.

Also applies to: 18-18

---

26-31: Verify the updated checksums match the actual source files.

The checksums have been updated for the new version. Before merging, manually verify these values against the actual downloaded files to ensure they are correct:

• cryptomator-1.18.0: 7102e5a6fdd196b4c0e7a479aa8c17fbee7822238b04960651d95cea40cf5646
• openjfx-25 x86_64: 96e520f48610d8ffb94ca30face1f11ffe8a977ddc1c4ff80b1a9e9f048bd94e
• openjfx-25 aarch64: 9ad4ca7b769ca4ee6419f1e99143dd6ff812f8be4fddb46a7d7cacbeea148af4

---

61-61: Please fetch (A) the 1.18.0 release notes / changelog to identify what cryptographic changes or new features were introduced. This will directly confirm whether the new jdk.crypto.ec and jdk.crypto.cryptoki modules are justified additions.

.SRCINFO (2)

3-3: Version updates are consistent with PKGBUILD.

The package version and OpenJFX noextract entry correctly reflect the updates in the PKGBUILD file.

Also applies to: 19-19

---

21-22: Source URLs and checksums are consistent with PKGBUILD.

The source entries and SHA256 checksum correctly match the corresponding values in the PKGBUILD file.

Also applies to: 24-24

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}