fix(unix): support X1/X2 mouse buttons in SGR parsing - #1117
Open
MaxAsif wants to merge 1 commit into
Open
Conversation
SGR mouse sequences for the X1/X2 (back/forward) buttons encode button numbers 8/9 by setting bit 7 of Cb, but parse_cb() only handled button numbers 0-7 and returned a parse error for anything else. Add MouseButton::X1/X2 and handle button numbers 8/9 for Down and Drag. Fixes crossterm-rs#1114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SGR mouse sequences for the X1/X2 (back/forward) buttons encode button numbers 8/9 by setting bit 7 of Cb, but parse_cb() only handled button numbers 0-7 and returned a parse error for anything else. Add MouseButton::X1/X2 and handle button numbers 8/9 for Down and Drag.
Fixes #1114