Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b379ae4
Preflight: Create helper for set and get the capabilities
praveenkumar Nov 21, 2025
94b6da1
Cached gvproxy to consume with macadam
praveenkumar Nov 14, 2025
85b6446
Cached macadam binary
praveenkumar Nov 17, 2025
5dcd27d
Add Logic to have different filename for cache
praveenkumar Nov 18, 2025
45e161e
ssh: Ensure parent directory exist before keypair generation
praveenkumar Nov 21, 2025
659f860
cluster: Don't apply pull secret patch
praveenkumar Nov 21, 2025
018e06d
Remove libmachine api and use macadam binary
praveenkumar Nov 28, 2025
978677e
systemd: Add result helper to get service exit result
praveenkumar Dec 16, 2025
56e69fd
systemd: Add helper to get service exit timestamp
praveenkumar Dec 16, 2025
a3a0615
vsock: Use gvclient to expose dns and ports
praveenkumar Dec 16, 2025
81a747e
cluster: Add WaitForServiceSuccessfullyFinished helper
praveenkumar Dec 16, 2025
5ae8a18
start: Copy the kubeconfig file from VM to host instead update
praveenkumar Dec 16, 2025
0e959be
Fixup: fix unit test for macadam and preflight
praveenkumar Dec 16, 2025
2557e7d
feat: Add cursor commit rules documentation
praveenkumar Jan 8, 2026
91a487c
build: Update source file discovery in Makefile
praveenkumar Jan 8, 2026
05a0690
refactor: Remove libvirt integration and update preflight checks
praveenkumar Jan 8, 2026
216b5c4
feat(systemd): Add WasSkippedDueToConditions method and handle skippe…
praveenkumar Jan 8, 2026
f31f855
Daemon: Remove virtual network implementation
praveenkumar Mar 16, 2026
45ed555
start: Don't return if growpart is run on existing grown disk
praveenkumar Mar 16, 2026
b32b21c
preflight: Replace libvirt VM removal with macadam integration
praveenkumar Mar 17, 2026
74d279b
e2e: Remove libvirt and virsh specific tests
praveenkumar Mar 19, 2026
63500c0
e2e: Remove the nodeport test
praveenkumar Apr 15, 2026
50e502e
Preflight: remove check and fix for vsock
praveenkumar Apr 16, 2026
d4acfe6
integration: Don't include resize test as part of integration suite
praveenkumar Apr 16, 2026
2484318
e2e: Remove developer pass change during stop => start
praveenkumar Apr 21, 2026
a506219
e2e: Use bytes for lsblk output parsing in partition size check
praveenkumar Apr 22, 2026
58e1700
daemon: Remove tcp fallback for 9p file sharing
praveenkumar Apr 27, 2026
174cdf3
hostsapi: add bearer token authentication to daemon hosts API
praveenkumar Aug 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
67 changes: 67 additions & 0 deletions .cursorrules
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# Cursor Commit Rules for crc-org/crc

When generating git commit messages:
- Follow the Conventional Commits specification format:
<type>[optional scope]: <subject>
[blank line]
[optional body explaining what changed and why]
[optional footer with references, breaking changes]
- Use **imperative** and **present tense** in the subject line.
- Limit the **subject line to ≈50–72 characters**; wrap body at ≈72.
- Use meaningful scopes when it clarifies affected modules (e.g., `pkg`, `cmd`, `docs`, `test`, `tools`).
- Prefer concise yet descriptive wording of **what changed** and **why**, not just **how**.
- When applicable, reference related issues or pull request numbers in footer.

# Allowed Commit Types
feat: add user-visible functionality or significant enhancements
fix: bug fix
docs: documentation only (e.g., README, docs/)
style: formatting, whitespace, linting (no code logic change)
refactor: code change that neither fixes a bug nor adds a feature
perf: performance improvement
test: adding or fixing tests
ci: continuous integration/config change (e.g., GitHub Actions)
build: build system or external dependency changes
chore: routine tasks without code change (scripts, config)

# Type Rules
feat:
- New CLI subcommands or flags
- New OpenShift, MicroShift, or podman integration options

fix:
- Correct unintended behaviors in cluster start/stop logic
- Resolve crashes, error cases, CLI UX bugs

docs:
- Add or update CRC documentation pages
- Fix README typos or incorrect instructions

style:
- Adjust formatting (go fmt), remove unused imports
- Linters fixes; no functional impact

refactor:
- Extract utils, reorganize package structure
- Rename internal functions for clarity

perf:
- Optimize CPU/memory usage in cluster operations

test:
- Add or improve unit/integration tests
- Update CI test matrix

ci:
- CI workflow fixes or adjustments (e.g., GitHub workflows)

build:
- Update Go module versions
- Changes to build scripts (Makefile, tooling)

chore:
- Non-code housekeeping (dependency cleanup, templating)

# Footer Conventions
- Close issues with “Closes #<number>.”
- Denote breaking changes via `BREAKING CHANGE:` in body/footer.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ORG := github.com/crc-org
MODULEPATH = $(ORG)/crc/v2
PACKAGE_DIR := packaging/$(GOOS)

SOURCES := $(shell git ls-files '*.go' ":^vendor")
SOURCES := $(shell find . -name '*.go' -not -path './vendor/*' -not -path './tools/vendor/*')
SOURCES := $(SOURCES) go.mod go.sum Makefile

RELEASE_INFO := release-info.json
Expand Down
5 changes: 1 addition & 4 deletions cmd/crc-embedder/cmd/embed.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/crc-org/crc/v2/pkg/crc/logging"
"github.com/crc-org/crc/v2/pkg/download"

"github.com/crc-org/crc/v2/pkg/crc/machine/libvirt"
"github.com/crc-org/crc/v2/pkg/crc/machine/vfkit"

"github.com/YourFin/binappend"
Expand All @@ -30,7 +29,6 @@ var (
const (
vfkitDriver = "vfkit-driver"
vfkitEntitlement = "vfkit-entitlement"
libvirtDriver = "libvirt-driver"
adminHelper = "admin-helper"
backgroundLauncher = "background-launcher"
)
Expand Down Expand Up @@ -114,8 +112,7 @@ var (
adminHelper: {constants.GetAdminHelperURLForOs("darwin"), 0755},
},
"linux": {
libvirtDriver: {libvirt.MachineDriverDownloadURL, 0755},
adminHelper: {constants.GetAdminHelperURLForOs("linux"), 0755},
adminHelper: {constants.GetAdminHelperURLForOs("linux"), 0755},
},
"windows": {
adminHelper: {constants.GetAdminHelperURLForOs("windows"), 0755},
Expand Down
Loading
Loading