Repository navigation
refactor(desktop): 簡化互動註冊與對話框命名 - #765
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增頁面/對話框原本必須同時更新 typed factory 與 DI 清單,容易留下不同步的型別登記。此 PR 由既有 factory 推導 31 個頁面與 8 個對話框的 transient 註冊,移除 47 筆重複手寫登記;缺少 enum mapping 時會在 composition 階段失敗。
AlertDialog、DownloadSetterDialog、UpgradingDialog,同步 XAML、引用與既有 analyzer baseline 的型別/路徑。fd31440。設計取捨、Parnas/Reflexion Models 論文與 Avalonia 官方範例的對照見 Desktop Feature Locality。保留 typed factory 與 XAML 各自的責任,沒有新增全域 registry 或名稱推測式 ViewLocator。
本機驗證:Windows x64、.NET SDK 11.0.100、clean commit
27f7c7a2d203229ce9813988801b3eba87f12cb3。script/test-solution.ps1 -Configuration Release -NoRestore -NoBuild:8 個 Windows 適用測試專案,2000 passed、0 failed;另有 1 個 Explicit 子程序 probe 不在一般回合直接執行。跨平台 exact-head CI 與 review 待 PR 執行。工作追蹤:DownKyiCore 工作項目「簡化桌面互動註冊與對話框命名」。