ci: run smoke and nightly e2e by shoom3301 · Pull Request #7965 · cowprotocol/cowswap

shoom3301 · 2026-08-05T12:55:53Z

Fixes https://linear.app/cowswap/issue/FE-435/create-gh-actions-to-run-tests-on-each-pr-smoke-and-full-regression

What changed

Remove Cypress entirely: the disabled integration-tests job in ci.yml, the @nx/cypress dependency, CYPRESS_* env vars in .env.local.example, and leftover cypress* ignore rules in apps/cowswap-frontend/.gitignore.
Update .mergify.yml merge-queue conditions from check-success=Cypress to check-success=smoke (the new Playwright smoke job).
Update a stale comment in vite.config.mts that referenced Cypress instead of Playwright.
Prune the now-unrelated pnpm-lock.yaml entries pulled in only by @nx/cypress.

Why

Cypress was already disabled (if: ${{ false }}) and fully superseded by the Playwright e2e suite (e2e-pw-smoke.yml, e2e-pw-nightly.yml). Keeping the dead job, its dependency, and its config references around was misleading and left the merge queue gated on a check that could never succeed.

QA Testing

Reviewer note: this is a CI/config cleanup with no app behavior change, so there's no browser-testable flow. Confirm instead that:

ci.yml no longer references Cypress and the notify-failure job's needs/env no longer mention integration-tests.
.mergify.yml conditions match the actual check names produced by e2e-pw-smoke.yml (job smoke) and e2e-pw-nightly.yml.
The Playwright smoke/nightly workflows still run correctly on their own triggers (PR paths / nightly schedule).

Summary by CodeRabbit

Testing
- Added nightly and manually triggered Playwright end-to-end test workflows.
- Added Playwright smoke testing for relevant changes, with report uploads and failure notifications.
- Replaced Cypress-based integration testing and related tooling with Playwright/Synpress workflows.
Documentation
- Updated testing instructions with required environment variables, cache generation, full-suite, smoke-test, and UI-mode commands.
Chores
- Updated merge checks to require successful smoke tests.
- Removed obsolete Cypress configuration, scripts, dependencies, and environment variables.

…l/cowswap into feat/e2e-playwright-3

vercel · 2026-08-05T12:55:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cowfi	Ready	Preview	Aug 13, 2026 9:51am
explorer-dev	Ready	Preview	Aug 13, 2026 9:51am
storybook	Ready	Preview	Aug 13, 2026 9:51am
swap-dev	Ready	Preview	Aug 13, 2026 9:51am
widget-configurator	Ready	Preview	Aug 13, 2026 9:51am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
cosmos	Ignored		Aug 13, 2026 9:51am
sdk-tools	Ignored	Preview	Aug 13, 2026 9:51am

coderabbitai · 2026-08-05T12:56:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a093b175-bf29-4eef-9799-aa08468b7a52

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

The PR removes Cypress integration-test CI and tooling, adds Playwright smoke and nightly workflows, updates merge checks, and replaces Cypress documentation with Playwright/Synpress instructions.

Changes

Playwright E2E migration

Layer / File(s)	Summary
Playwright workflow execution `.github/workflows/e2e-pw-smoke.yml`, `.github/workflows/e2e-pw-nightly.yml`	Adds pull-request smoke tests and scheduled or manual sharded E2E tests. Both workflows install Chromium and upload reports.
CI and merge-check integration `.github/workflows/ci.yml`, `.mergify.yml`	Removes Cypress result handling from CI notifications. Queue and auto-merge rules now require the `smoke` check.
Cypress tooling and documentation cleanup `README.md`, `apps/cowswap-frontend/.gitignore`, `apps/cowswap-frontend/vite.config.mts`, `package.json`	Replaces Cypress instructions with Playwright/Synpress instructions and removes Cypress scripts, dependencies, comments, and ignore rules.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant Playwright
  participant ReportArtifact
  participant Slack
  GitHubActions->>Playwright: Install Chromium and run E2E tests
  Playwright->>ReportArtifact: Upload Playwright reports
  GitHubActions->>Slack: Post failed nightly run details

Possibly related PRs

cowprotocol/cowswap#7859: Modifies Cypress integration-test CI configuration.
cowprotocol/cowswap#7958: Removes Cypress tooling while transitioning E2E coverage to Playwright.

Suggested reviewers: azebuado, kernelwhisperer

Poem

A rabbit hops through Playwright’s gate,
Four shards run while testers wait.
Cypress rests beneath the sun,
Smoke checks guard each merge run.
Reports rise, and Slack bells ring.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding smoke and nightly end-to-end test workflows.
Description check	✅ Passed	The description explains the changes, motivation, issue reference, and targeted QA checks, although it does not use all template headings.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/e2e-playwright-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…l/cowswap into feat/e2e-playwright-3

linear-code · 2026-08-06T10:50:44Z

FE-435

…l/cowswap into feat/e2e-playwright-3

azebuado · 2026-08-10T15:08:56Z

@coderabbitai review

coderabbitai · 2026-08-10T15:09:05Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/e2e-pw-smoke.yml:
- Around line 5-10: Remove the restrictive paths filter from the smoke workflow
in .github/workflows/e2e-pw-smoke.yml so the required smoke check runs for every
mergeable pull request. In .mergify.yml lines 5-13, keep check-success=smoke
unchanged because it will then be available for all queue-eligible pull
requests; no direct change is required there.
- Line 26: Harden both workflows by adding persist-credentials: false to the
actions/checkout steps in .github/workflows/e2e-pw-smoke.yml:26 and
.github/workflows/e2e-pw-nightly.yml:22, and set job-level permissions to
contents: read unless a write permission is required. Apply the same
minimal-permissions configuration to both workflow files.

In `@README.md`:
- Around line 161-165: Update the CI workflow that runs pnpm e2e:smoke to
provision the .cache-synpress directory beforehand by invoking e2e:build-cache
or restoring a valid cache artifact. Ensure the smoke-test job can run on a
clean runner, and revise the README wording so the cache is not described as
covered for real-wallet fixtures without corresponding CI setup.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e0d3bb13-75a8-4eb9-ac1a-64c9e321856c

📥 Commits

Reviewing files that changed from the base of the PR and between 0d64709 and 7986cbc.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (9)

.env.local.example
.github/workflows/ci.yml
.github/workflows/e2e-pw-nightly.yml
.github/workflows/e2e-pw-smoke.yml
.mergify.yml
README.md
apps/cowswap-frontend/.gitignore
apps/cowswap-frontend/vite.config.mts
package.json

💤 Files with no reviewable changes (3)

.env.local.example
apps/cowswap-frontend/.gitignore
package.json

azebuado

Minor question

…l/cowswap into feat/e2e-playwright-3 # Conflicts: # pnpm-lock.yaml

…l/cowswap into feat/e2e-playwright-3

shoom3301 added 2 commits August 5, 2026 14:42

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

bfa0940

…l/cowswap into feat/e2e-playwright-3

chore: delete cypress

50aa99b

shoom3301 self-assigned this Aug 5, 2026

shoom3301 requested a review from a team August 5, 2026 12:56

shoom3301 added the e2e label Aug 5, 2026

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

3fc5d52

…l/cowswap into feat/e2e-playwright-3

shoom3301 mentioned this pull request Aug 5, 2026

feat: e2e tests with playwright #7961

Open

shoom3301 added 3 commits August 5, 2026 15:12

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

0a3a1c3

…l/cowswap into feat/e2e-playwright-3

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

02ce9ec

…l/cowswap into feat/e2e-playwright-3

chore: revert

a67c3c7

shoom3301 requested review from azebuado and kernelwhisperer August 7, 2026 11:26

shoom3301 and others added 4 commits August 10, 2026 10:20

chore: remove slack notification from smoke

abedb95

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

463b1f8

…l/cowswap into feat/e2e-playwright-3

chore: update bundle sizes [automatic]

ba7d7aa

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

7986cbc

…l/cowswap into feat/e2e-playwright-3

coderabbitai Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread .github/workflows/e2e-pw-smoke.yml

Comment thread .github/workflows/e2e-pw-smoke.yml

Comment thread README.md Outdated

azebuado approved these changes Aug 10, 2026

View reviewed changes

Comment thread .github/workflows/e2e-pw-nightly.yml

Comment thread .github/workflows/e2e-pw-smoke.yml

shoom3301 added 5 commits August 11, 2026 10:57

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

a53f387

…l/cowswap into feat/e2e-playwright-3 # Conflicts: # pnpm-lock.yaml

chore: update lock

7bfcaf8

chore: fix workflows

afdff68

Merge branch 'feat/e2e-playwright-2' of https://github.com/cowprotoco…

797279d

…l/cowswap into feat/e2e-playwright-3

chore: change slack channel

4558f5f

Navigation Menu

Uh oh!

ci: run smoke and nightly e2e - #7965

ci: run smoke and nightly e2e#7965
shoom3301 wants to merge 15 commits into
feat/e2e-playwright-2from
feat/e2e-playwright-3

shoom3301 commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Aug 5, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

Review skipped

Uh oh!

linear-code Bot commented Aug 6, 2026

Uh oh!

azebuado commented Aug 10, 2026

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azebuado left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shoom3301 commented Aug 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why

QA Testing

Summary by CodeRabbit

Uh oh!

vercel Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

linear-code Bot commented Aug 6, 2026

Uh oh!

azebuado commented Aug 10, 2026

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azebuado left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shoom3301 commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Aug 5, 2026 •

edited

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading