Conversation
Collaborator
|
@yn224 thank you! can you please also add at least one test case to CI/CD test? Just want to have a test case running through Vitis HLS and make sure it can work. |
Contributor
Author
|
@hecmay Would it be possible for this to get merged? Also, what would be the state where the loop names generate different numbers appended to loop names during CI/CD tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue: #435
Detailed description: This PR attempts to add support for examples where the top function does not include "loops" but rather have separate loop function instances. The interface does not differ much from the previous iteration.
Link to the tests: Added under
tests/test_hls_report.py