Add Jest Test Infrastructure and Comprehensive Tests for User - #54
Open
Shengle-Dai wants to merge 3 commits into
Open
Add Jest Test Infrastructure and Comprehensive Tests for User#54Shengle-Dai wants to merge 3 commits into
Shengle-Dai wants to merge 3 commits into
Conversation
✅ Deploy Preview for curaise ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Arsh-S
reviewed
Feb 16, 2026
Collaborator
There was a problem hiding this comment.
Nice work on the pr! this will be really useful for us. Just had one comment to add:
In a few tests there is:
mockSupabaseAuth.getUser.mockResolvedValue({
data: { user: createMockSupabaseUser(userId) },
});
but the supabase.auth.getUser() and default mock return both data and error:
{ data: { user: ... }, error: null }
You could make the overrides always include error: null or add a small helper func like setAuthenticatedUser() that sets the full shape for consistency. That’ll help us avoid tests breaking if auth logic ever checks error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Jest testing infrastructure with ts-jest, along with mocks and fixtures for Prisma, Supabase, and Express. It adds comprehensive unit and E2E tests for the User domain (services, handlers, and router), ensuring coverage of authentication, validation, and data access flows.
Added tests for:
Notes: