Skip to content

Required elements - #652

Closed
eicyer wants to merge 1 commit into
netid-validationfrom
required-elements
Closed

Required elements#652
eicyer wants to merge 1 commit into
netid-validationfrom
required-elements

Conversation

@eicyer

@eicyer eicyer commented Jan 5, 2026

Copy link
Copy Markdown
Member

Add visual indicators to required form fields across the application to
improve UX. Updated Label component to support required prop and added indicators to employee, location, ride, and rider forms. MUI components

This pull request is the first step towards having asterisks in required form fields.

Test Plan

I tested manually.

use required prop; DatePicker/TimePicker use asterisks in label strings.
Screenshot 2026-01-06 at 12 07 43 AM
Screenshot 2026-01-06 at 12 07 43 AM
Screenshot 2026-01-06 at 12 07 43 AM

Screenshot 2026-01-05 at 11 10 59 PM Screenshot 2026-01-05 at 11 10 59 PM Screenshot 2026-01-05 at 11 10 59 PM

Notes

I focused on the forms explicitly mentioned in the Jira ticket.
The same validation logic can be easily extended to other forms with minimal additional code if needed.

@eicyer
eicyer requested a review from a team as a code owner January 5, 2026 21:14
@dti-github-bot

dti-github-bot commented Jan 5, 2026

Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 86.

@mjaydenkim
mjaydenkim changed the base branch from master to netid-validation January 6, 2026 01:44
@mjaydenkim

Copy link
Copy Markdown
Contributor

Before I review this PR, wanted to note that a lot of teh changes are from netid-validation so I'll review that one first. In general, it's best to start a new PR based on the contents of master, not another PR, unless one is fully dependent on the other (which may very well be true, I just haven't checked yet).

@eicyer
eicyer force-pushed the required-elements branch from 727ce34 to 90db46b Compare January 6, 2026 07:07
improve UX. Updated Label component to support `required` prop and added
indicators to employee, location, ride, and rider forms. MUI components
use `required` prop; DatePicker/TimePicker use asterisks in label strings.
@eicyer
eicyer force-pushed the required-elements branch from 90db46b to ac3ecd2 Compare January 6, 2026 07:27
@eicyer

eicyer commented Jan 6, 2026

Copy link
Copy Markdown
Member Author

Before I review this PR, wanted to note that a lot of teh changes are from netid-validation so I'll review that one first. In general, it's best to start a new PR based on the contents of master, not another PR, unless one is fully dependent on the other (which may very well be true, I just haven't checked yet).

Thanks for calling that out.
I’ve rebased the work onto master and opened a new PR that contains only the relevant changes.
I’ll close this PR and continue on #653

@eicyer eicyer closed this Jan 6, 2026
@eicyer

eicyer commented Jan 6, 2026

Copy link
Copy Markdown
Member Author

Closing in favor of #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants