Add Rewind destination for ring music gestures - #375
Open
voijoi wants to merge 1 commit into
Open
Conversation
The ring's music gestures could route to play/pause, next track or nothing; there was no way to jump backwards, which audiobook and podcast listeners need. Adds a PreviousTrack destination wired the same way as NextTrack end to end: routing enum, preference encoding, switchboard entry (SkipPrevious icon), action handler, and the expect/actual dispatch, with Android sending KEYCODE_MEDIA_PREVIOUS exactly as onNextTrack sends KEYCODE_MEDIA_NEXT and iOS a no-op to match. Written with AI assistance; reviewed and hardware-tested by the submitter on a Pixel 10 Pro with an Index ring against Listen Audiobook Player. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ring's music gestures can route to play/pause, next track or nothing — there's no way to jump backwards, which audiobook and podcast listeners need at least as often as skipping forward.
This adds a
PreviousTrackdestination wired identically toNextTrackend to end: routing enum, preference encoding (previous_track), switchboard entry ("Rewind", SkipPrevious icon), action handler, and the expect/actual dispatch — Android sendsKEYCODE_MEDIA_PREVIOUSexactly asonNextTracksendsKEYCODE_MEDIA_NEXT; iOS is a no-op matching the existing pattern. 37 insertions across 7 files, no behaviour change for existing routes.Written with AI assistance (Claude); I have reviewed every line and hardware-tested on a Pixel 10 Pro + Index ring against Listen Audiobook Player, verifying the position moves straight back via
dumpsys media_session.🤖 Generated with Claude Code