third_party/nimble: pull fix for GATT resource count leak on reset - #2043
Open
gmarull wants to merge 1 commit into
Open
third_party/nimble: pull fix for GATT resource count leak on reset#2043gmarull wants to merge 1 commit into
gmarull wants to merge 1 commit into
Conversation
ble_gatts_reset() left the pool-sizing counters that ble_gatts_count_cfg() accumulates untouched, so every bt_driver_stop() followed by bt_driver_start() re-counted the services and grew the pools ble_gatts_start() allocates from the kernel heap. Pull the fix that clears the counters in ble_gatts_reset(), proposed upstream in apache/mynewt-nimble#2294. Fixes FIRM-3741 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1861 by fixing the leak in NimBLE itself instead of resetting the
ble_hs_priv.hcounters from the driver.ble_gatts_reset()left the pool-sizing counters thatble_gatts_count_cfg()accumulates untouched, so everybt_driver_stop()followed bybt_driver_start()re-counted the services and grew the poolsble_gatts_start()allocates from the kernel heap. The submodule now points at thegatts-reset-counters-pebbleosbranch of coredevices/mynewt-nimble, which carries the fix on top of 1.10.0. The same patch is proposed upstream in apache/mynewt-nimble#2294.The fork branch stays unmerged until this PR is approved.
Fixes FIRM-3741
🤖 Generated with Claude Code