-
Notifications
You must be signed in to change notification settings - Fork 1
bug:ENG-20249 fix counter index in getLineInformation #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryan2445
merged 7 commits into
main
from
ENG-20249_PR-files-for-review-line-expansion-shows-incorrect-lines
Aug 6, 2026
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6d00369
fix counter index in getLineInformation
ryan2445 8fb637f
make release workflow
ryan2445 f1b70c8
update build-test.yml action versions
ryan2445 6f0f125
coderabbit fixes
ryan2445 adbab9f
remove verbose validation + add workflow dispatch
ryan2445 38133a3
coderabbit review
ryan2445 a127443
coderabbit review
ryan2445 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| name: Publish | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
| workflow_dispatch: | ||
|
|
||
| # Read-only by default; the publish job opts into `packages: write`. | ||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: publish-${{ github.event.release.tag_name || github.ref_name }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| publish: | ||
| name: Publish to GitHub Packages | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read # checkout | ||
| packages: write # npm publish to npm.pkg.github.com | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| ref: ${{ github.sha }} | ||
| fetch-depth: 0 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@copia-automation' | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Lint | ||
| run: yarn lint | ||
|
|
||
| - name: Build | ||
| run: yarn build | ||
|
|
||
| - name: Test | ||
| run: yarn test | ||
|
|
||
| - name: Publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PUBLISH_NEXT: ${{ (github.event_name == 'workflow_dispatch' || github.event.release.prerelease) && 'true' || 'false' }} | ||
| run: | | ||
| if [ "$PUBLISH_NEXT" != 'true' ]; then | ||
| npm publish --tag latest | ||
| exit 0 | ||
| fi | ||
|
|
||
| NAME="$(node -p 'require("./package.json").name')" | ||
| VERSION="$(node -p 'require("./package.json").version')" | ||
|
|
||
| # `next` must only ever point at a prerelease version, e.g. 4.1.0-rc.1. | ||
| if [[ "${VERSION%%+*}" != *-* ]]; then | ||
| echo "::error::Refusing to publish stable version $VERSION to the next tag; bump package.json to a prerelease version first." | ||
| exit 1 | ||
|
ryan2445 marked this conversation as resolved.
|
||
| fi | ||
|
|
||
| # A manual run on an already-published prerelease only moves the tag. | ||
| if npm view "$NAME@$VERSION" version >/dev/null 2>&1; then | ||
| echo "$NAME@$VERSION is already published; retagging as next." | ||
| npm dist-tag add "$NAME@$VERSION" next | ||
| else | ||
| npm publish --tag next | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24.19.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.