Adds static analysis to the ci - #4454
Merged
btovar merged 12 commits intoAug 20, 2026
Merged
Conversation
btovar
force-pushed
the
fix/static-analysis-ci
branch
2 times, most recently
from
August 20, 2026 17:09
11c579f to
b278c2a
Compare
uses native ubuntu rather than our docker images
…al-run bugs Regenerated scan-build-suppressions.txt from a fresh two-pass --strict scan-build run (263 confirmed findings, up from 136 -- checker names and line numbers had drifted since the file was last generated). Also fixes two bugs hit while regenerating locally in a conda dev shell: - comm requires the same collation as sort, or it spuriously reports "not in sorted order" and aborts the script via set -e before it can report its outcome. - ccc-analyzer/c++-analyzer default to plain gcc/g++ off PATH for their real compile step unless told otherwise, which can differ from the compiler this tree was actually configured with (e.g. conda's gcc vs. the distro's) and trip spurious -Werror failures under --strict that don't occur with the tree's own compiler. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Findings under third-party/vendored lua or sqlite paths are dropped in scan-build-parse.py, the single point both the baseline-generation and CI-comparison call sites go through, so they never enter the baseline or get flagged as new. Also drops the now-stale dttools/src/luapatt.c entries from the suppressions baseline.
Pins the scan-build job's clang version to match pixi.toml's local dev env instead of drifting with whatever ubuntu-latest's default clang-tools resolves to, since checker names/locations in scan-build-suppressions.txt can shift across clang versions. clang-tools-22 isn't in the apt archive before Ubuntu 26.04, so the job now pins runs-on explicitly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
btovar
force-pushed
the
fix/static-analysis-ci
branch
from
August 20, 2026 17:29
b278c2a to
0f71903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks only chunks of texts modified by a pr.
It also adds valgrind checks.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.