Repository navigation
don't debounce if it's already scheduled sooner - #16
Merged
Merged
Conversation
commit: |
reeceyang
approved these changes
Aug 20, 2026
ianmacartney
added a commit
that referenced
this pull request
Aug 21, 2026
Currently, if you `ping` a `BatchWorker` that is going to execute in 3s, but you pass debounceMs of 10s, then it'll re-schedule the worker to run in 10s instead. We should instead bias towards running sooner, so timeoutMs is respected when a worker returns that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you
pingaBatchWorkerthat is going to execute in 3s, but you pass debounceMs of 10s, then it'll re-schedule the worker to run in 10s instead.We should instead bias towards running sooner, so timeoutMs is respected when a worker returns that