firewall: fix DNS accept rule port on internal networks with custom dns_port - #1509
Open
ajoshua2004 wants to merge 1 commit into
Open
firewall: fix DNS accept rule port on internal networks with custom dns_port#1509ajoshua2004 wants to merge 1 commit into
ajoshua2004 wants to merge 1 commit into
Conversation
…ns_port the INPUT accept rule was hard coded to check port 53, but when a custom dns_port is configured the DNAT redirect rewrites the destination port before the packet reaches INPUT, so the accept rule never matched. Fixes: containers#1508 Signed-off-by: Joshua Arrevillaga <2004jarrevillaga@gmail.com>
Member
|
Sure, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The INPUT accept rule was hardcoded to check port 53, but when a custom dns_port is configured the DNAT redirect rewrites the destination port before the packet reaches INPUT, so the accept rule never matched. Changed it to use
network_setup.dns_portinstead.Fixes: #1508