Fix Io metadata reference after Builder move - #355
Merged
connormanning merged 1 commit intoJun 2, 2026
Merged
Conversation
Io stores const Metadata& from Builder construction. When Builder is move-constructed, the default move leaves Laszip referencing the moved-from metadata (empty schema), breaking chunk serialization. Recreate io from the new metadata and endpoints in move ctor/assign. Add unit test asserting io->metadata aliases moved.metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metadata&/Endpoints&inIoafterBuilderis move-constructed or move-assigned.Laszip(and otherIoimplementations) capture references at construction; the compiler-generated move movedunique_ptr<Io>but left those references pointing at the moved-fromBuildermetadata (empty schema), causing chunk serialization to fail withFailed to find dimension: X.ioviaIo::create(metadata, endpoints)in the move constructor and move assignment operator.build.movedBuilderIoMetadataunit test: afterstd::move,io->metadatamust aliasmoved.metadataand a full build still writes tiles.Context
The CLI path
Builder builder = builder::create(config)uses guaranteed copy elision and does not hit this bug. Embedding code that move-constructsBuilder(e.g.std::make_shared<Builder>(builder::create(config))) does.Test plan
build.movedBuilderIoMetadata— move alias + end-to-end build on ellipsoid.laztest/unit/build.cpp)