Zero out header point counts when crafting a zero-point file - #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do a shallow
info, we manually grab the header/VLRs/EVLRs for remote LAS/LAZ files and smash them together, without the point data, to frankenstein a file so that we can use PDAL to extract its metadata. We did this without modifying the point count fields in the header so that this field would be extracted as well.However for uncompressed LAS files, PDAL has a check which compares the point data size with the expected size from the header's point count, so we would run into the error:
For LAZ, this check doesn't happen since the expected file size cannot be determined.
To fix this, this PR does the following:
inforesultCloses #328 and #332.