envelope: decode without copying the body - #264
Open
allada wants to merge 1 commit into
Open
Conversation
Widen decode and decode_with_limit to impl Buf + Deref<Target = [u8]> and take the payload with copy_to_bytes, which Bytes and BytesMut both specialize to a refcount handoff. The gRPC unary, server-streaming and Connect client-streaming paths now decode straight out of the collected body instead of staging a BytesMut copy. Source-breaking for callers that relied on deref coercion to the old &mut BytesMut parameter. Signed-off-by: Blaise Bruer <github.blaise@allada.com>
allada
force-pushed
the
worktree-envelope-zero-copy-decode
branch
from
August 1, 2026 23:35
4f8319c to
7bfd5a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen decode and decode_with_limit to impl Buf + Deref<Target = [u8]> and take the payload with copy_to_bytes, which Bytes and BytesMut both specialize to a refcount handoff. The gRPC unary, server-streaming and Connect client-streaming paths now decode straight out of the collected body instead of staging a BytesMut copy.