Add WithRequestGate handler option - #962
Open
emcfarlane wants to merge 1 commit into
Open
Conversation
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the handler option
WithRequestGatethat runs after the request headers are available and before any message is received. Returning an error rejects the RPC before the interceptor chain and before the request is decompressed or unmarshaled.Checks like authentication are recommended at the HTTP layer, and RFC 002 added authn-go for that. However, users still reach for interceptors where unary RPCs run interceptors after the decode. This provides an in-library option that registers alongside interceptors ands voids this issue. Gates run for every stream type.