Set finite default for ReadMaxBytes - #961
Closed
emcfarlane wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
Contributor
Author
|
Closing, as I believe it to be too disruptive. This default will be set in v2 and the migrate tool will set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set a default
ReadMaxBytesof 4 MiB for both clients and handlers. Both previously defaulted to no limit.The limit applies per message. Messages over the limit fail with
CodeResourceExhausted.This is a behavior change for anyone relying on unbounded reads.
WithReadMaxBytes(0)restores the previous behavior, and existingWithReadMaxBytes(n)calls are unaffected. Handlers that want to bound the total size of a request stream rather than individual messages should still usehttp.MaxBytesHandler.