Omit archive file_name during conversion - #533
Closed
rogierx wants to merge 1 commit into
Closed
Conversation
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @rogierx. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1335), and ping the bot to refresh the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #500 by omitting V0
source.fnwhen converting URL-based archive sources to V1 recipes.fnwas previously moved tofile_name, butfile_nameis not valid for archive source URLs in rattler-build recipes. The converter now detects archive source URLs, removesfn, and emits a warning so users know the filename override could not be translated directly.Validation
PYTHONPATH=/tmp/crm-test-deps:$PWD /opt/anaconda3/bin/python -m pytest tests/parser/test_recipe_parser_convert.py -q -k 'boto or pytest_pep8 or pytest-pep8'PYTHONPATH=/tmp/crm-test-deps:$PWD /opt/anaconda3/bin/python -m pytest tests/parser/test_recipe_parser_convert.py -q