Skip to content

Omit archive file_name during conversion - #533

Closed
rogierx wants to merge 1 commit into
conda:mainfrom
rogierx:omit-archive-file-name-convert
Closed

Omit archive file_name during conversion#533
rogierx wants to merge 1 commit into
conda:mainfrom
rogierx:omit-archive-file-name-convert

Conversation

@rogierx

@rogierx rogierx commented May 17, 2026

Copy link
Copy Markdown

Summary

Fixes #500 by omitting V0 source.fn when converting URL-based archive sources to V1 recipes.

fn was previously moved to file_name, but file_name is not valid for archive source URLs in rattler-build recipes. The converter now detects archive source URLs, removes fn, and emits a warning so users know the filename override could not be translated directly.

Validation

  • PYTHONPATH=/tmp/crm-test-deps:$PWD /opt/anaconda3/bin/python -m pytest tests/parser/test_recipe_parser_convert.py -q -k 'boto or pytest_pep8 or pytest-pep8'
  • PYTHONPATH=/tmp/crm-test-deps:$PWD /opt/anaconda3/bin/python -m pytest tests/parser/test_recipe_parser_convert.py -q

@conda-bot

Copy link
Copy Markdown
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @rogierx.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1335), and ping the bot to refresh the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert: what to do with fn and archive source files

3 participants