Skip to content

Avoid duplicate blank lines after multiline sections - #528

Closed
ada-powerful wants to merge 1 commit into
conda:mainfrom
ada-powerful:fix-multiline-section-blank-lines
Closed

Avoid duplicate blank lines after multiline sections#528
ada-powerful wants to merge 1 commit into
conda:mainfrom
ada-powerful:fix-multiline-section-blank-lines

Conversation

@ada-powerful

Copy link
Copy Markdown

Summary

  • avoid adding an extra top-level separator when the previous rendered line is already blank
  • add a regression for a multiline string followed by the next top-level section
  • update the selector-filtering expected output to keep one section separator

Closes #527.

Validation

  • conda env create -p ./.conda-test -f environment.yaml
  • pytest tests/parser/test_recipe_reader.py tests/parser/test_recipe_variant.py -q
  • pytest tests/parser -q
  • git diff --check

@conda-bot

Copy link
Copy Markdown
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @ada-powerful.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1331), and ping the bot to refresh the PR.

@schuylermartin45

Copy link
Copy Markdown
Collaborator

This has all the tell-tale signs of an LLM bot, not to mention the near-identical PR #529 filed a few hours later, I'm closing this.

I guess this is what I get for using good-first-issue these days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate blank lines in sections ending in a multi-line string

3 participants