Skip to content

Expect InvalidVersion from packaging if version is not string #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frenzymadness wants to merge 1 commit into from
+2 −1
Closed

Expect InvalidVersion from packaging if version is not string #6092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conda_build/deprecations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import warnings
from argparse import Action
from functools import wraps
from packaging.version import InvalidVersion
from types import ModuleType
from typing import TYPE_CHECKING

Expand Down Expand Up @@ -75,7 +76,7 @@ def _version_less_than(self: Self, version: str) -> bool:
if self._version_object is None:
try:
self._version_object = parse(self._version) # type: ignore[arg-type]
except TypeError:
except (TypeError, InvalidVersion):
# TypeError: self._version could not be parsed
self._version_object = parse("0.0.0.dev0+placeholder")
return self._version_object < parse(version)
Expand Down