Skip to content

Fix Postgres Annotation Field - #427

Open
the-powerpointer wants to merge 4 commits into
concourse:masterfrom
the-powerpointer:patch-1
Open

Fix Postgres Annotation Field#427
the-powerpointer wants to merge 4 commits into
concourse:masterfrom
the-powerpointer:patch-1

Conversation

@the-powerpointer

@the-powerpointer the-powerpointer commented Aug 5, 2026

Copy link
Copy Markdown

Bug: Wrong value path used for configMapAnnotations+secretAnnotations annotation rendering

When postgresql.configMapAnnotations is set, the annotation block renders .Values.postgresql.annotations (the StatefulSet annotations) instead of .Values.postgresql.configMapAnnotations. The same mistake exists in

  • postgres-env-configmap.yaml
  • postgres-config-override-configmap.yaml

Users setting configMapAnnotations will get the wrong annotations applied.

Similarly, when postgresql.secretAnnotations is set, the template references .Values.postgresql.primary.annotations instead of .Values.postgresql.secretAnnotations. This means the annotations block will always render garbage/empty content (or fail) when a user sets postgresql.secretAnnotations, and the intended annotations are never applied.

  • postgres-secret.yaml

Bug: accessModes references the wrong (singular) value key

The VolumeClaimTemplate uses .Values.postgresql.persistence.accessMode (singular), but the README and values documentation define the key as postgresql.persistence.accessModes (plural, a list). When accessModes is set in values, this line will silently fall back to the hardcoded default ["ReadWriteOnce"] and ignore the user's configuration.

  • postgres-statefulset.yaml

Contributor Checklist

  • Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 5, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@taylorsilva

Copy link
Copy Markdown
Member

Thanks for the PR. Adding it to my PR review board to eventually review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants