Fix Postgres Annotation Field - #427
Open
the-powerpointer wants to merge 4 commits into
Open
Conversation
Member
|
Thanks for the PR. Adding it to my PR review board to eventually review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Wrong value path used for
configMapAnnotations+secretAnnotationsannotation renderingWhen
postgresql.configMapAnnotationsis set, the annotation block renders.Values.postgresql.annotations(the StatefulSet annotations) instead of.Values.postgresql.configMapAnnotations. The same mistake exists inUsers setting
configMapAnnotationswill get the wrong annotations applied.Similarly, when
postgresql.secretAnnotationsis set, the template references .Values.postgresql.primary.annotationsinstead of.Values.postgresql.secretAnnotations. This means the annotations block will always render garbage/empty content (or fail) when a user setspostgresql.secretAnnotations, and the intended annotations are never applied.Bug:
accessModesreferences the wrong (singular) value keyThe VolumeClaimTemplate uses
.Values.postgresql.persistence.accessMode(singular), but the README and values documentation define the key aspostgresql.persistence.accessModes(plural, a list). WhenaccessModesis set in values, this line will silently fall back to the hardcoded default["ReadWriteOnce"]and ignore the user's configuration.Contributor Checklist
masteris for changes related to the current release of theconcourse/concourse:latestimage and should be good to publish immediatelyReviewer Checklist
masterordev)