Repository navigation
ci: Re-enable bootc revdep CI - #402
Merged
cgwalters merged 1 commit intoSep 25, 2026
Merged
Conversation
cgwalters-bot
force-pushed
the
bot/reenable-bootc-revdep
branch
from
September 25, 2026 15:54
b020175 to
d01571d
Compare
Collaborator
|
@cgwalters-bot add my signoff |
Release 0.7.0 disabled this job until bootc main caught up with the composefs-rs API. That has now happened: bootc-dev/bootc#2248 (the adapt-composefs-rs-v1-erofs-2 branch we were pinned to) is merged, and bootc main depends on composefs-rs by git tag v0.9.2, so the [patch] override in bootc/Justfile applies to our workspace version again. Test against bootc main as before. This also drops the if: never(), which isn't a valid expression function: the workflow file failed to parse, so every push to any branch recorded a failed run with no jobs instead of skipping it. Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters-bot
force-pushed
the
bot/reenable-bootc-revdep
branch
from
September 25, 2026 16:42
d01571d to
f2b439d
Compare
Contributor
Author
|
Added your sign-off (promote now also signs off where the DCO app runs); same for #401. Generated-by: https://github.com/cgwalters/#llms |
cgwalters
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.7.0 (469f6d6) disabled the bootc reverse dependency job "until bootc main updates", pinning it to the
cgwalters/bootcadapt-composefs-rs-v1-erofs-2branch in the meantime. That branch has now landed as bootc-dev/bootc#2248. bootc main depends on composefs-rs by git tagv0.9.2, and our workspace version is still 0.9.2, so the[patch]override inbootc/Justfileapplies to it again. This re-enables the job against bootc main, the same way 6b026f4 did the last time.It also fixes a side effect of the disable:
never()isn't a valid Actions expression function, so the workflow file failed to parse. As a result, every push to any branch (includinggh-readonly-queue/*and Renovate branches) recorded a failed run with no jobs. The workflow now has 1000+ such runs.Alternatives considered
if: false, or dropping the automatic triggers and keepingworkflow_dispatch. An earlier version of this branch did the latter. Now that bootc main has caught up, that would just keep the test off for no reason.ci/bootclabel, as proposed for bootc's operator revdep job). The job isn't part ofrequired-checks, so a failure doesn't block merging. Before 0.7.0 it ran on every PR, so this keeps it that way. Gating is easy to add later if the ~2h runs turn out to be too costly.Testing
actionlint: theundefined function "never"error is gone. The remaining output is two shellcheck infos in the pre-existing "Install tmt" step.mainnow that the file parses). For comparison, pushes of another branch based on currentmainto the same fork each recorded a failed 0-job run, e.g. https://github.com/cgwalters-forge/composefs-rs/actions/runs/35946914814.pull_requestrun against bootc main: https://github.com/cgwalters-forge/composefs-rs/actions/runs/35947623278. It passed in 42 minutes: bootc main at 41049cca was built with this tree patched in (bootc patched for composefs-rs at b020175, all composefs crates compiled from the local path), and both tmt plans passed (plan-01-readonly,plan-24-image-upgrade-reboot, sealed UKI + systemd-boot).workflow_dispatchwasn't exercised separately; it is unchanged.Generated-by: https://github.com/cgwalters/#llms