Skip to content

ui: unregister interactive timeout callbacks - #38660

Closed
danielpolimac wants to merge 1 commit into
commaai:masterfrom
danielpolimac:fix/interactive-timeout-callback-lifecycle
Closed

ui: unregister interactive timeout callbacks#38660
danielpolimac wants to merge 1 commit into
commaai:masterfrom
danielpolimac:fix/interactive-timeout-callback-lifecycle

Conversation

@danielpolimac

Copy link
Copy Markdown

Summary

Add interactive-timeout callback removal and tie callbacks owned by temporary cabin-camera and onboarding widgets to their show and hide lifecycle.

Callback registration is idempotent, removal is safe when already absent, and timeout dispatch uses a snapshot so a callback can hide its widget and unregister itself without skipping the next callback.

Closes #37536

Validation

  • Added coverage for duplicate registration and idempotent removal.
  • Added coverage for unregistering during callback dispatch.
  • 2 tests passed.
  • Ruff and git diff checks passed.

@github-actions github-actions Bot added the ui label Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@danielpolimac

Copy link
Copy Markdown
Author

The failing unit tests and Create UI Report jobs are blocked by the missing Raylib headless runtime dependency (libGLESv2.so.2), before this change runs. #38619 contains the isolated CI fix and is fully green. All remaining checks on this PR pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

interactive timeout callbacks are added but never removed

2 participants