Skip to content

car: reset calibration when car changes - #38659

Closed
danielpolimac wants to merge 1 commit into
commaai:masterfrom
danielpolimac:fix/reset-calibration-car-switch
Closed

car: reset calibration when car changes#38659
danielpolimac wants to merge 1 commit into
commaai:masterfrom
danielpolimac:fix/reset-calibration-car-switch

Conversation

@danielpolimac

Copy link
Copy Markdown

Summary

Reset the saved camera calibration when the newly fingerprinted car differs from the previous route.

Calibration is specific to the device mounting geometry. Reusing it after moving a device to a different car can start the next drive with invalid extrinsics. The comparison runs before CarParams is published, so calibrationd observes the reset before loading its cached state.

Closes #38351

Validation

  • Added regression coverage for preserving calibration on the same fingerprint.
  • Added regression coverage for resetting calibration on a different fingerprint.
  • 2 tests passed.
  • Ruff and git diff checks passed.

@github-actions github-actions Bot added the car vehicle-specific label Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@danielpolimac

Copy link
Copy Markdown
Author

The failing unit tests and Create UI Report jobs are blocked by the missing Raylib headless runtime dependency (libGLESv2.so.2), before this change runs. #38619 contains the isolated CI fix and is fully green. All remaining checks on this PR pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car vehicle-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset calibration on switching cars

2 participants