car: reset calibration when car changes - #38659
Closed
danielpolimac wants to merge 1 commit into
Closed
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
Author
|
The failing unit tests and Create UI Report jobs are blocked by the missing Raylib headless runtime dependency (libGLESv2.so.2), before this change runs. #38619 contains the isolated CI fix and is fully green. All remaining checks on this PR pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset the saved camera calibration when the newly fingerprinted car differs from the previous route.
Calibration is specific to the device mounting geometry. Reusing it after moving a device to a different car can start the next drive with invalid extrinsics. The comparison runs before CarParams is published, so calibrationd observes the reset before loading its cached state.
Closes #38351
Validation