fix(x402): do not silently flip HTTP method on 404 (Python) - #1414
Open
SashaMIT wants to merge 1 commit into
Open
fix(x402): do not silently flip HTTP method on 404 (Python)#1414SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Parity with TypeScript coinbase#1405. make_http_request retried a 404 with the opposite method, which can turn an intended GET into a POST write on services that map both methods to one path. Return the 404 with an explicit hint instead. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sibling of #1405 (TypeScript). Python
make_http_requeststill retried a 404 with the HTTP method flipped (GET↔POST) and the caller's body attached. On services that map both methods to one path, that silently converts an intended read into a write the agent never chose.Fix
Return the 404 with a hint naming the method tried, so switching methods becomes an explicit agent decision (same shape as #1405).
Testing
cd python/coinbase-agentkit uv run pytest tests/action_providers/x402/test_x402_action_provider.py::test_make_http_request_404_does_not_flip_method \ tests/action_providers/x402/test_x402_action_provider.py::test_make_http_request_success \ tests/action_providers/x402/test_x402_action_provider.py::test_make_http_request_402 -q3 passed.
Made with Cursor