Skip to content

feat: prevent users from removing themselves from team #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7eliassen merged 2 commits into from
Aug 17, 2026
Merged

feat: prevent users from removing themselves from team #304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
922f29f
feat: check is user try to delete himself
7eliassen Jul 9, 2026
bfefe60
feat: add test
7eliassen Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/presentation/http/router/noteSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ const NoteSettingsRouter: FastifyPluginCallback<NoteSettingsRouterOptions> = (fa
return reply.forbidden('You can\'t remove note\'s creator from the team');
}

if (request.userId === request.body.userId) {
return reply.forbidden('You can\'t remove yourself from the team');
}
Comment thread
Reversean marked this conversation as resolved.

const deletedTeamMemberId = await noteSettingsService.removeTeamMemberByUserIdAndNoteId(userId, noteId);

if (deletedTeamMemberId === undefined) {
Expand Down
Loading