Skip to content

CAT Hackathon: retrieving normalization for skimmed files - #78

Open
jmalvaso wants to merge 2 commits into
cms-tau-pog:hackathonfrom
jmalvaso:hackathon
Open

jmalvaso wants to merge 2 commits into
cms-tau-pog:hackathonfrom
jmalvaso:hackathon

Conversation

@jmalvaso

Copy link
Copy Markdown
Collaborator

No description provided.

self.year = kwargs.get('year', 2022 ) # integer, e.g. 2017, 2018
self.era = kwargs.get('era', '2022postEE' ) # string, e.g. '2017', 'UL2017'
self.ees = kwargs.get('ees', 1.0 ) # electron energy scale
self.tes = kwargs.get('tes', None ) # tau energy scale; if None, recommended values are applied

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmalvaso @pmastrap In general it's better to not change these default settings if it's for your own personal reasons, because it might break other people's setups. If you want to disable this, you need to do so via your sample list or the way you define the channel. (Anyway, I'll try to make this easier / more clear in the new configuration paradigm.)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IzaakWN Should I restore these setting to the default value and create a new pull request or, for this time, it is fine like this?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to just add a commit that undoes changing these defaults if that's okay with you?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's fine. I will do it asap

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IzaakWN I think I added the commit in the proper way, but please let me know if it's ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants