Skip to content

Adding missing beamspot for track scouting DQM and module reordering [16_1_X] - #51879

Open
jprendi wants to merge 3 commits into
cms-sw:CMSSW_16_1_Xfrom
jprendi:scoutJME_DQM_qfix_16_1_X
Open

jprendi wants to merge 3 commits into
cms-sw:CMSSW_16_1_Xfrom
jprendi:scoutJME_DQM_qfix_16_1_X

Conversation

@jprendi

@jprendi jprendi commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

PR description:

Crash reported by @etzovara in last Friday's HLT Scouting meeting.

This PR adds missing onlineBeamSpotProducer to the start of recoTrackFromScoutingMonitorSequence in HLTriggerOffline/Scouting/python/RecoTrackFromScoutingMonitor_cff.py.
It also swaps the ordering in DQMOffline/HLTScouting/python/HLTScoutingDqmOffline_cff.py of hltScoutingTrackMonitor and recoTrackFromScoutingMonitorSequence s.t. recoTrackFromScoutingMonitorSequence goes first, as hltScoutingTrackMonitor also consumes the online beam spot.

PR validation:

As provided by @etzovara :

cmsrel CMSSW_16_1_3
cd CMSSW_16_1_3/src/
cmsenv
python3 /cvmfs/cms.cern.ch/el9_amd64_gcc13/cms/cmssw/CMSSW_17_0_0_pre5/src/Configuration/DataProcessing/test/RunPromptReco.py --scenario=ppEra_Run3_2025 --reco --aod --miniaod --global-tag 160X_dataRun3_Prompt_v1 --lfn=root://eoscms.cern.ch//eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2026/ScoutingPFMonitor/RAW/v8214952/000/398/191/00000/fc45bd25-297f-47b6-a28a-b215c9121574.root --dqmio --dqmSeq=@hltScouting
cmsRun -e RunPromptRecoCfg.py

from which the job completed successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #51878

FYI @mmusich

@cmsbuild

cmsbuild commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @jprendi for CMSSW_16_1_X.

It involves the following packages:

  • DQMOffline/HLTScouting (dqm)
  • HLTriggerOffline/Scouting (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @mtosi, @rociovilar this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@mmusich

mmusich commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

type ngt, bug-fix

@mmusich

mmusich commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

backport of #51878

@mmusich

mmusich commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13ed9c/55840/summary.html
COMMIT: 1e26f65
CMSSW: CMSSW_16_1_X_2026-09-14-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51879/55840/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 18 errors in the following unit tests:

---> test TestDQMOfflineConfiguration_10 had ERRORS
---> test TestDQMServicesDemo had ERRORS
---> test test_MC_23_crosscheck had ERRORS
and more ...

Failed RelVals

----- Begin Fatal Exception 14-Sep-2026 13:43:19 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
The Path/EndPath configuration could cause the job to deadlock
  module 'hltTrackValidator' is on path 'prevalidation_step' and depends on module 'hltOnlineBeamSpot'
  module 'hltOnlineBeamSpot' is on path 'dqmoffline_step' and follows module 'BTagMu_AK4DiJet20_Mu5' on the path
  module 'BTagMu_AK4DiJet20_Mu5' is on path 'dqmoffline_step' and depends on module 'slimmedMuons'
  module 'slimmedMuons' is in a task and depends on module 'selectedPatMuons'
  module 'selectedPatMuons' is in a task and depends on module 'patMuons'
  module 'patMuons' is in a task and depends on module 'muonMatch'
  module 'muonMatch' is in a task and depends on module 'prunedGenParticles'
  module 'prunedGenParticles' is on path 'prevalidation_step' and follows module 'hltTrackValidator' on the path
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 14-Sep-2026 13:20:14 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
The Path/EndPath configuration could cause the job to deadlock
  module 'hltObjectsMonitor4all' is on path 'dqmoffline_step' and depends on module 'hltOnlineBeamSpot'
  module 'hltOnlineBeamSpot' is on path 'dqmoffline_step' and follows module 'hltObjectsMonitor4all' on the path
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 14-Sep-2026 13:37:58 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
The Path/EndPath configuration could cause the job to deadlock
  module 'hltTrackValidator' is on path 'prevalidation_step' and depends on module 'hltOnlineBeamSpot'
  module 'hltOnlineBeamSpot' is on path 'dqmoffline_step' and follows module 'BTagMu_AK4DiJet20_Mu5' on the path
  module 'BTagMu_AK4DiJet20_Mu5' is on path 'dqmoffline_step' and depends on module 'slimmedMuons'
  module 'slimmedMuons' is in a task and depends on module 'selectedPatMuons'
  module 'selectedPatMuons' is in a task and depends on module 'patMuons'
  module 'patMuons' is in a task and depends on module 'muonMatch'
  module 'muonMatch' is in a task and depends on module 'prunedGenParticles'
  module 'prunedGenParticles' is on path 'prevalidation_step' and follows module 'hltTrackValidator' on the path
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@mmusich

mmusich commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

allow @jprendi test rights

1 similar comment
@mmusich

mmusich commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

allow @jprendi test rights

@jprendi

jprendi commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #51879 was updated. @ctarricone, @gabrielmscampos, @rseidita can you please check and sign again.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13ed9c/55855/summary.html
COMMIT: e68ede0
CMSSW: CMSSW_16_1_X_2026-09-14-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51879/55855/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4182605
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4182582
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants