Add tests for `edm::FileInPath` and fix number of corner cases by makortel · Pull Request #51867 · cms-sw/cmssw

makortel · 2026-09-11T21:24:29Z

PR description:

In order to address #51757, this PR first adds unit tests for edm::FileInPath. While generating the test code my AI agent discovered 3 more corner cases that are not handled well, and this PR fixes those too. I then asked the AI agent to create tests for more corner cases, which it did, and that are fixed as well. I defer to the individual commits for the exact details of the changes.

The behavior of the FileInPath with respect to the typical cases of CMSSW_SEARCH_PATH and CMSSW_BASE/CMSSW_RELEASE_BASE/CMSSW_DATA_PATH should remain unchanged.

Resolves #51757
Resolves cms-sw/framework-team#2407

PR validation:

Added unit tests pass.

Assisted-By: Kilo:claude-opus-4 Kilo:claude-sonnet-5

… directory that does not match to any of local/release/data top Assisted-By: Copilot:claude-sonnet-5

…o any of {local,release,data} top

…data} areas

…rc directory

cmsbuild · 2026-09-11T21:25:03Z

cms-bot internal usage

cmsbuild · 2026-09-11T21:40:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51867/50910

cmsbuild · 2026-09-11T21:41:07Z

A new Pull Request was created by @makortel for master.

It involves the following packages:

FWCore/Utilities (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2026-09-11T21:45:24Z

test parameters:

full_cmssw = true

To run all unit tests

makortel · 2026-09-11T21:45:30Z

@cmsbuild, please test

cmsbuild · 2026-09-11T23:57:20Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 88KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab372f/55811/summary.html
COMMIT: a8e37e5
CMSSW: CMSSW_20_1_X_2026-09-11-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51867/55811/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

Assisted-by: Kilo:claude-opus-4

…ment is given To make the behavior more consistent with with FileInPath constructor

…arch areas

…rSetBlob() if the input is truncated Assisted-By: Copilot:claude-sonnet-5

…EARCH_PATH

… in search paths instead of string functions Assisted-By: Copilot:claude-sonnet-5

…owing if dataTop environment variable is not set

cmsbuild · 2026-09-14T16:00:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51867/50927

cmsbuild · 2026-09-14T16:00:32Z

Pull request #51867 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

makortel · 2026-09-14T16:11:58Z

@cmsbuild, please test

cmsbuild · 2026-09-14T18:17:37Z

-1

Failed Tests: Build
Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab372f/55854/summary.html
COMMIT: 14e1468
CMSSW: CMSSW_20_1_X_2026-09-14-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51867/55854/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation warning when building: See details on the summary page.

makortel added 6 commits September 11, 2026 16:07

Add tests for FileInPath

153c4d8

Assisted-By: Kilo:claude-opus-4 Kilo:claude-sonnet-5

Avoid infinite loop when a FileInPath is found from CMSSW_SEARCH_PATH…

9221c3d

… directory that does not match to any of local/release/data top Assisted-By: Copilot:claude-sonnet-5

Issue a warning message if CMSSW_SEARCH_PATH element does not match t…

c970c6a

…o any of {local,release,data} top

Throw an exception if an absolute path is given

9e076fc

Treat empty search path element as not matched to the {local,release,…

686b405

…data} areas

Replace assert() with an exception if src symlink does not point to s…

05fda5e

…rc directory

makortel mentioned this pull request Sep 11, 2026

Infinite loop in edm::FileInPath #51757

Open

cmsbuild added this to the CMSSW_20_1_X milestone Sep 11, 2026

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 11, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 11, 2026

cmsbuild added tests-started and removed tests-pending labels Sep 11, 2026

cmsbuild added tests-rejected and removed tests-started labels Sep 11, 2026

makortel added 5 commits September 14, 2026 10:57

Added more tests for FileInPath corner cases

2d36925

Assisted-by: Kilo:claude-opus-4

Throw an exception in findFile() if an absolute path or an empty argu…

48a3169

…ment is given To make the behavior more consistent with with FileInPath constructor

Throw an exception if relative path would go outside of any of the se…

3e131b5

…arch areas

Leave FileInPath member data untouched in read() and readFromParamete…

b786e46

…rSetBlob() if the input is truncated Assisted-By: Copilot:claude-sonnet-5

Make FileInPath behavior unaffected by later manipulations of CMSSW_S…

eb09c5f

…EARCH_PATH

makortel added 3 commits September 14, 2026 10:57

Check with filesystem functions in FileInPath::write() if the file is…

6443114

… in search paths instead of string functions Assisted-By: Copilot:claude-sonnet-5

Document current behavior for whitespace in paths

6a897bb

Degrade to special value in readFromParameterSetBlob() instead of thr…

14e1468

…owing if dataTop environment variable is not set

makortel force-pushed the fileInPath branch from a8e37e5 to 14e1468 Compare September 14, 2026 15:57

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Sep 14, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 14, 2026

cmsbuild added tests-started and removed tests-pending labels Sep 14, 2026

cmsbuild added tests-rejected and removed tests-started labels Sep 14, 2026

Navigation Menu

Uh oh!

Add tests for `edm::FileInPath` and fix number of corner cases - #51867

Add tests for `edm::FileInPath` and fix number of corner cases#51867
makortel wants to merge 14 commits into
cms-sw:masterfrom
makortel:fileInPath

makortel commented Sep 11, 2026

Uh oh!

cmsbuild commented Sep 11, 2026 •

edited

Loading

Uh oh!

cmsbuild commented Sep 11, 2026

Uh oh!

cmsbuild commented Sep 11, 2026

Uh oh!

makortel commented Sep 11, 2026

Uh oh!

makortel commented Sep 11, 2026

Uh oh!

cmsbuild commented Sep 11, 2026

Uh oh!

cmsbuild commented Sep 14, 2026

Uh oh!

cmsbuild commented Sep 14, 2026

Uh oh!

makortel commented Sep 14, 2026

Uh oh!

cmsbuild commented Sep 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

makortel commented Sep 11, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 11, 2026

Uh oh!

cmsbuild commented Sep 11, 2026

Uh oh!

makortel commented Sep 11, 2026

Uh oh!

makortel commented Sep 11, 2026

Uh oh!

cmsbuild commented Sep 11, 2026

Failed Clang Build

Uh oh!

cmsbuild commented Sep 14, 2026

Uh oh!

cmsbuild commented Sep 14, 2026

Uh oh!

makortel commented Sep 14, 2026

Uh oh!

cmsbuild commented Sep 14, 2026

Failed Build

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cmsbuild commented Sep 11, 2026 •

edited

Loading