Add HepMC3 input source - #51842
Add HepMC3 input source#51842
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51842/50873 |
|
A new Pull Request was created by @tvami for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
FYI @cms-sw/generators-l2 |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
hi @makortel I have a few things waiting on the top of this, could you please review and sign? |
|
I wonder though why |
I guess IO was meant to for |
765439e to
26ef5dd
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51842/50935 |
|
Pull request #51842 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
|
@makortel thanks for your review, I've changed things according to your comments |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
hi @makortel do you have any further comments, or is this ready for your approval? |
|
Comparison differences are related to #47071 |
|
+core |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Adds
MCFileSource3, an input source reading HepMC3 event files, the HepMC3 counterpart ofMCFileSource. CMSSW already hasedm::HepMC3ProductandGenEventInfoProduct3as event records, andBaseEvtVtxGenerator,GeneratorSmearedProducer,GenParticleProducerandRunManagerMTWorkeralready consume them, but there was no way to get an externally produced HepMC3 file into the framework.New
HepMC3FileReaderwrapsHepMC3::deduce_reader, so ASCII HepMC3, ASCII HepMC2, LHEF and HEPEVT files (and their compressed flavours) are all accepted, a list of files is read as a single event stream, and units are forced to GeV/mm. The source putsHepMC3ProductandGenEventInfoProduct3with instance labelgenerator, hasfillDescriptions, and takes an untrackedprintEventflag to dump the event content.No change to any existing output: the new source is only used if a configuration asks for it.
PR validation:
New test configuration
IOMC/Input/test/testReader3_cfg.py. Validated on a 100 event HepMC3 file with displaced dimuon decays:source->VtxSmeared->generatorSmearedruns, givingHepMC3Productat each step;MCFileSourcegive bit-identicalreco::GenParticlecollections: 700 particles, zero difference in pdgId, status, four-momentum, mass, production vertex and mother/daughter structure, and identical event weights;MCFileSource3works, confirming the format deduction;If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, no backport foreseen.