Skip to content

Add GEMs to FastSim [17_0_X] - #51811

Merged
cmsbuild merged 9 commits into
cms-sw:CMSSW_17_0_Xfrom
kpedro88:fastSim_GEM_17_0_0_pre2
Sep 13, 2026
Merged

Add GEMs to FastSim [17_0_X]#51811
cmsbuild merged 9 commits into
cms-sw:CMSSW_17_0_Xfrom
kpedro88:fastSim_GEM_17_0_0_pre2

Conversation

@kpedro88

@kpedro88 kpedro88 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

backport of #51810

@cmsbuild cmsbuild added this to the CMSSW_17_0_X milestone Sep 2, 2026
@cmsbuild

cmsbuild commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51811/50805

@cmsbuild

cmsbuild commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @kpedro88 for CMSSW_17_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • Configuration/StandardSequences (operations)
  • FastSimulation/Configuration (fastsim)
  • FastSimulation/MuonSimHitProducer (fastsim)
  • SimGeneral/MixingModule (simulation)
  • SimGeneral/PreMixingModule (simulation)
  • SimMuon/GEMDigitizer (simulation)
  • SimMuon/MCTruth (simulation)
  • Validation/MuonCSCDigis (dqm)
  • Validation/MuonHits (dqm)

@AdrianoDee, @DickyChant, @antoniovagnerini, @civanch, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @rseidita, @sroychow, @ssekmen can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @VinInn, @VourMa, @abbiendi, @cericeci, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @fsimone91, @giovanni-mocellin, @jhgoh, @jshlee, @llunerti, @makortel, @martinamalberti, @matt-komm, @mmasciov, @mmusich, @mtosi, @rovere, @sameasy, @sbein, @slomeo, @trocino, @watson-ij this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88

kpedro88 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 140KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9c9d/55665/summary.html
COMMIT: fed8800
CMSSW: CMSSW_17_0_X_2026-09-02-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51811/55665/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 17034.9617034.96_TTbar_14TeV+2025PU_HybridPUS1S2/step2_TTbar_14TeV+2025PU_HybridPUS1S2.log

AMD_MI300X Comparison Summary

There are some workflows for which there are errors in the baseline:
34634.402 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 96 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 355 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 207036
  • DQMHistoTests: Total failures: 25136
  • DQMHistoTests: Total nulls: 35
  • DQMHistoTests: Total successes: 181865
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 52 log files, 53 edm output root files, 12 DQM output files
  • TriggerResults: found differences in 4 / 11 workflows

AMD_W7900 Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 397 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 222745
  • DQMHistoTests: Total failures: 31215
  • DQMHistoTests: Total nulls: 34
  • DQMHistoTests: Total successes: 191496
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
  • Checked 54 log files, 55 edm output root files, 13 DQM output files
  • TriggerResults: found differences in 1 / 12 workflows

NVIDIA_H100 Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 408 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 222745
  • DQMHistoTests: Total failures: 31947
  • DQMHistoTests: Total nulls: 30
  • DQMHistoTests: Total successes: 190768
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
  • Checked 54 log files, 55 edm output root files, 13 DQM output files
  • TriggerResults: found differences in 3 / 12 workflows

NVIDIA_L4 Comparison Summary

Summary:

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 393 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 222745
  • DQMHistoTests: Total failures: 29851
  • DQMHistoTests: Total nulls: 29
  • DQMHistoTests: Total successes: 192865
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
  • Checked 54 log files, 55 edm output root files, 13 DQM output files
  • TriggerResults: found differences in 3 / 12 workflows

NVIDIA_T4 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 373 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 222745
  • DQMHistoTests: Total failures: 30780
  • DQMHistoTests: Total nulls: 35
  • DQMHistoTests: Total successes: 191930
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
  • Checked 54 log files, 55 edm output root files, 13 DQM output files
  • TriggerResults: found differences in 1 / 12 workflows

Max Memory Comparisons exceeding threshold NVIDIA_H100

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 34634.712_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnly step3 max memory diff -70.2 exceeds +/- 30.0 MiB

Max Memory Comparisons exceeding threshold NVIDIA_L4

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 34634.712_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnly step3 max memory diff 79.8 exceeds +/- 30.0 MiB

@cmsbuild

cmsbuild commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

-1

Size: This PR adds an extra 88KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9c9d/55694/summary.html
COMMIT: cbf39b4
CMSSW: CMSSW_17_0_X_2026-09-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51811/55694/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2533 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 5154
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4332441
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2476.029 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 13234.0,... ): 795.429 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 13234.0,... ): 11.438 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 13234.0,... ): 6.500 KiB GEM/Digis
  • DQMHistoSizes: changed ( 13234.0,... ): 4.602 KiB GEM/Pad
  • DQMHistoSizes: changed ( 13234.0,... ): 4.223 KiB GEM/PadCluster
  • DQMHistoSizes: changed ( 13234.0,... ): 3.071 KiB GEM/SimHits
  • DQMHistoSizes: changed ( 13234.0,... ): 0.080 KiB Muons_miniAOD/MuonRecoAnalyzer
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

NVIDIA_L4 Comparison Summary

Summary:

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 397 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 222745
  • DQMHistoTests: Total failures: 33475
  • DQMHistoTests: Total nulls: 35
  • DQMHistoTests: Total successes: 189235
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
  • Checked 54 log files, 55 edm output root files, 13 DQM output files
  • TriggerResults: found differences in 5 / 12 workflows

NVIDIA_T4 Comparison Summary

Summary:

Max Memory Comparisons exceeding threshold NVIDIA_T4

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 34634.712_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnly step3 max memory diff 79.7 exceeds +/- 30.0 MiB

@kpedro88

kpedro88 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

See discussion in #51810.

Here, we see yet another different instance of #47071, this time in 34434.0.

@kpedro88

kpedro88 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

ignore tests-rejected with manual-override

@kpedro88

kpedro88 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

+1

@gabrielmscampos

gabrielmscampos commented Sep 8, 2026

Copy link
Copy Markdown
Member

+dqm

@antoniovagnerini

antoniovagnerini commented Sep 11, 2026

Copy link
Copy Markdown

+pdmv

@cmsbuild

cmsbuild commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_17_0_X IBs (test failures were overridden) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini

ftenchini commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit bbfbe65 into cms-sw:CMSSW_17_0_X Sep 13, 2026
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-ok code-checks-approved dqm-approved fastsim-approved fully-signed operations-approved orp-approved pdmv-approved simulation-approved tests-approved tests-manual-override

Projects

None yet

Milestone

CMSSW_17_0_X

Development

Successfully merging this pull request may close these issues.

6 participants

@kpedro88 @cmsbuild @gabrielmscampos @antoniovagnerini @ftenchini @yeckang