Skip to content

Update dictionary package assignment for TrackingVertex-reco::Vertex associations - #51700

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
makortel:lostDictVertex
Aug 14, 2026
Merged

Update dictionary package assignment for TrackingVertex-reco::Vertex associations#51700
cmsbuild merged 1 commit into
cms-sw:masterfrom
makortel:lostDictVertex

Conversation

@makortel

Copy link
Copy Markdown
Contributor

PR description:

Following #51577 (comment)

Resolves cms-sw/framework-team#2390

PR validation:

Running duplicateReflexLibrarySearch.py --lostDefs locally no longer shows the warnings.

@cmsbuild

cmsbuild commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • Utilities/ReleaseScripts (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35d2f2/55325/summary.html
COMMIT: 5d04c1b
CMSSW: CMSSW_20_1_X_2026-08-13-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51700/55325/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3435544
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3435526
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

ignore tests-rejected with external-failure

@makortel

Copy link
Copy Markdown
Contributor Author

@smuzaffar Could you sign if this change looks good to you?

@smuzaffar

Copy link
Copy Markdown
Contributor

+core

looks good

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 20afb38 into cms-sw:master Aug 14, 2026
9 of 10 checks passed
@makortel
makortel deleted the lostDictVertex branch August 14, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update duplicateReflexLibrarySearch.py for #51577

4 participants